From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17557 invoked by alias); 2 Sep 2007 20:59:09 -0000 Received: (qmail 17549 invoked by uid 22791); 2 Sep 2007 20:59:09 -0000 X-Spam-Check-By: sourceware.org Received: from pauline.vellum.cz (HELO pauline.vellum.cz) (89.250.243.234) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 02 Sep 2007 20:59:02 +0000 Received: from host0.dyn.jankratochvil.net (localhost.localdomain [127.0.0.1]) by pauline.vellum.cz (8.12.11.20060308/8.12.11) with ESMTP id l82Kwv8R030292; Sun, 2 Sep 2007 22:58:57 +0200 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.1/8.13.8) with ESMTP id l82KwvP8006174; Sun, 2 Sep 2007 22:58:57 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.1/8.14.1/Submit) id l82Kwunj006173; Sun, 2 Sep 2007 22:58:56 +0200 Date: Sun, 02 Sep 2007 20:59:00 -0000 From: Jan Kratochvil To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org Subject: Re: Back-Cover Text and --version updates Message-ID: <20070902205855.GA6164@host0.dyn.jankratochvil.net> References: <20070902140855.GA6993@caradoc.them.org> <20070902200216.GA21817@caradoc.them.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="/Uq4LBwYP4y1W6pO" Content-Disposition: inline In-Reply-To: <20070902200216.GA21817@caradoc.them.org> User-Agent: Mutt/1.5.14 (2007-02-12) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00018.txt.bz2 --/Uq4LBwYP4y1W6pO Content-Type: text/plain; charset=iso-2022-jp Content-Disposition: inline Content-length: 1259 On Sun, 02 Sep 2007 22:02:16 +0200, Daniel Jacobowitz wrote: ... > Thanks for the review. I've checked it in now. gcc-4.1.2-17.x86_64 gcc -c -m64 -ggdb2 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -I. -I.././gdb -I.././gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I.././gdb/../include/opcode -I.././gdb/../readline/.. -I../bfd -I.././gdb/../bfd -I.././gdb/../include -DMI_OUT=1 -DTUI=1 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wno-switch -Wno-char-subscripts -Werror top.c top.c: In function ‘print_gdb_version’: top.c:1157: error: missing terminating " character top.c:1161: error: stray ‘\’ in program top.c:1161: error: ‘and’ undeclared (first use in this function) top.c:1161: error: (Each undeclared identifier is reported only once top.c:1161: error: for each function it appears in.) top.c:1161: error: expected ‘)’ before string constant cc1: warnings being treated as errors top.c:1161: warning: format not a string literal and no format arguments make[2]: *** [top.o] Error 1 I expect I do not have to ask for such commit approval. Regards, Jan --/Uq4LBwYP4y1W6pO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="gdb-eol.patch" Content-length: 734 2007-09-02 Jan Kratochvil * top.c (print_gdb_version): Fixed an end-of-line compiler error. --- gdb/top.c 2 Sep 2007 20:02:12 -0000 1.124 +++ gdb/top.c 2 Sep 2007 20:55:35 -0000 @@ -1157,7 +1157,7 @@ print_gdb_version (struct ui_file *strea fprintf_filtered (stream, "\ License GPLv3+: GNU GPL version 3 or later \n\ This is free software: you are free to change and redistribute it.\n\ -There is NO WARRANTY, to the extent permitted by law. Type \"show copying\" +There is NO WARRANTY, to the extent permitted by law. Type \"show copying\"\n\ and \"show warranty\" for details.\n"); /* After the required info we print the configuration information. */ --/Uq4LBwYP4y1W6pO--