Re: [RFA/testsuite] Increase expect buffer size (related to GPLv3)

[Daniel Jacobowitz <drow@false.org>]

On Thu, Aug 23, 2007 at 03:56:24PM -0400, Joel Brobecker wrote:
> Hello,
> 
> After switching "info copying/warranty" to GPLv3, the testsuite showed
> one regression (expected), and two ERRORs because of expect buffer
> overflow. The overflow comes from the fact that the GPLv3 terms are
> much longer than the terms in GPLv2.
> 
> I think the attached patch is the appropriate change, but perhaps
> there is a way to change the buffer size locally for the test or
> the testcase, instead of expanding it globally for all testcases.
> I really don't think that growing the buffer to 30kb (from 20kb)
> is a big deal, but perhaps it has some effects that I haven't noticed
> (like performance hits)... Hence the RFA rather than committing it
> using the obvious rule.
> 
> 2007-08-23  Joel Brobecker  <brobecker@adacore.com>
> 
>         * lib/gdb.exp (default_gdb_init): Increase expect buffer size
>         to 30000 (from 20000).
> 
> Tested on x86-linux. No regression.
> OK to apply?

This is fine.  It is also possible to do locally; instead of a single
gdb_test, use gdb_test_multiple and match other lines of text using
"exp_continue" to keep looking for the prompt.  There's some examples
of this already.  But bumping up the limit to a nice bounded value is
fine too.

-- 
Daniel Jacobowitz
CodeSourcery