From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21002 invoked by alias); 23 Aug 2007 20:08:06 -0000 Received: (qmail 20714 invoked by uid 22791); 23 Aug 2007 20:08:03 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 23 Aug 2007 20:07:58 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 71D009810B; Thu, 23 Aug 2007 20:07:58 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 2108C9810A; Thu, 23 Aug 2007 20:07:58 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IOIyA-0002rO-TQ; Thu, 23 Aug 2007 16:07:54 -0400 Date: Thu, 23 Aug 2007 20:08:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/testsuite] Increase expect buffer size (related to GPLv3) Message-ID: <20070823200754.GA10856@caradoc.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20070823195624.GC6056@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070823195624.GC6056@adacore.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00451.txt.bz2 On Thu, Aug 23, 2007 at 03:56:24PM -0400, Joel Brobecker wrote: > Hello, > > After switching "info copying/warranty" to GPLv3, the testsuite showed > one regression (expected), and two ERRORs because of expect buffer > overflow. The overflow comes from the fact that the GPLv3 terms are > much longer than the terms in GPLv2. > > I think the attached patch is the appropriate change, but perhaps > there is a way to change the buffer size locally for the test or > the testcase, instead of expanding it globally for all testcases. > I really don't think that growing the buffer to 30kb (from 20kb) > is a big deal, but perhaps it has some effects that I haven't noticed > (like performance hits)... Hence the RFA rather than committing it > using the obvious rule. > > 2007-08-23 Joel Brobecker > > * lib/gdb.exp (default_gdb_init): Increase expect buffer size > to 30000 (from 20000). > > Tested on x86-linux. No regression. > OK to apply? This is fine. It is also possible to do locally; instead of a single gdb_test, use gdb_test_multiple and match other lines of text using "exp_continue" to keep looking for the prompt. There's some examples of this already. But bumping up the limit to a nice bounded value is fine too. -- Daniel Jacobowitz CodeSourcery