Re: [Patch]: Fix sockethost handling in board config

[Daniel Jacobowitz <drow@false.org>]

On Mon, Aug 20, 2007 at 02:28:39PM +0200, Markus Deuling wrote:
> Daniel Jacobowitz schrieb:
> >>
> >> this patch fixes handling of gdbserver parameter in 
> >> testsuite/lib/gdbserver-support.exp. When using the testsuite remotely there 
> >> are two parameters possible for remote host configuration:
> >> sockethost and socketport. Currently sockethost is ignored. 
> > Why does it need to be fixed?  gdbserver doesn't do anything with the
> > hostname, so there's no need to pass it, and the existing sockethost
> > variable is honored.  That's "sockethost", not "gdb,sockethost".
> 
> Neither "sockethost" nor "gdb,sockethost" is honored currently.

That is incorrect.

    if [target_info exists sockethost] {
        set debughost  [target_info sockethost]
    } else {
        set debughost "localhost:"
    }

The sockethost is passed to gdb.

> The hostname isnt passed to the gdbserver command.  

Gdbserver doesn't use the hostname, so why should it be passed?

> Why is it gdb,socketport and sockethost?!? I think it makes sense to name the 
> two
> variables in the same way. They are a pair that belongs together.

True.  However, there is an existing and working name.  If you change
the name, you're going to break any other working board
configurations.

-- 
Daniel Jacobowitz
CodeSourcery