From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18304 invoked by alias); 20 Aug 2007 12:47:45 -0000 Received: (qmail 18189 invoked by uid 22791); 20 Aug 2007 12:47:44 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 20 Aug 2007 12:47:38 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id D06F1980C1; Mon, 20 Aug 2007 12:47:37 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id A0AA8980BF; Mon, 20 Aug 2007 12:47:37 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IN6fP-0002PY-4L; Mon, 20 Aug 2007 08:47:35 -0400 Date: Mon, 20 Aug 2007 12:47:00 -0000 From: Daniel Jacobowitz To: Markus Deuling Cc: Ulrich Weigand , GDB Patches Subject: Re: [Patch]: Fix sockethost handling in board config Message-ID: <20070820124735.GA9058@caradoc.them.org> Mail-Followup-To: Markus Deuling , Ulrich Weigand , GDB Patches References: <46C92424.2040503@de.ibm.com> <20070820113153.GB5195@caradoc.them.org> <46C988F7.1030102@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46C988F7.1030102@de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00391.txt.bz2 On Mon, Aug 20, 2007 at 02:28:39PM +0200, Markus Deuling wrote: > Daniel Jacobowitz schrieb: > >> > >> this patch fixes handling of gdbserver parameter in > >> testsuite/lib/gdbserver-support.exp. When using the testsuite remotely there > >> are two parameters possible for remote host configuration: > >> sockethost and socketport. Currently sockethost is ignored. > > Why does it need to be fixed? gdbserver doesn't do anything with the > > hostname, so there's no need to pass it, and the existing sockethost > > variable is honored. That's "sockethost", not "gdb,sockethost". > > Neither "sockethost" nor "gdb,sockethost" is honored currently. That is incorrect. if [target_info exists sockethost] { set debughost [target_info sockethost] } else { set debughost "localhost:" } The sockethost is passed to gdb. > The hostname isnt passed to the gdbserver command. Gdbserver doesn't use the hostname, so why should it be passed? > Why is it gdb,socketport and sockethost?!? I think it makes sense to name the > two > variables in the same way. They are a pair that belongs together. True. However, there is an existing and working name. If you change the name, you're going to break any other working board configurations. -- Daniel Jacobowitz CodeSourcery