From: Joel Brobecker <brobecker@adacore.com>
To: Jerome Guitton <guitton@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/testsuite] backtrace in mixed language application
Date: Wed, 15 Aug 2007 18:57:00 -0000 [thread overview]
Message-ID: <20070815190110.GI11498@adacore.com> (raw)
In-Reply-To: <20070810101003.GA33739@adacore.com>
Hello Jerome,
> 2007-08-10 Jerome Guitton <guitton@adacore.com>
>
> * gdb.ada/lang_switch/lang_switch.adb: New file.
> * gdb.ada/lang_switch/foo.c: Ditto.
> * gdb.ada/lang_switch.exp: New testcase.
This looks fine to me, save for one little thing: Make sure to add
the copyright headers to foo.c and lang_switch.adb as well.
That reminds me that we're trying to move to GPLv3, and your patch
actually refers to GPLv2. I think it's fine for this patch, we'll
fix it later with the rest of the files when we manage to do the
transition. But do give this a few days for people to object before
you commit.
One tiny comment: I would prefer if foo.c followed the GNU coding
standards too, so would you mind formatting it so that the function
name starts at the beginning of the line?
Thanks,
--
Joel
next prev parent reply other threads:[~2007-08-15 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 10:10 Jerome Guitton
2007-08-15 18:57 ` Joel Brobecker [this message]
2007-08-15 19:01 ` Daniel Jacobowitz
2007-08-15 19:17 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070815190110.GI11498@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
--cc=guitton@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox