From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28633 invoked by alias); 15 Aug 2007 18:57:31 -0000 Received: (qmail 28533 invoked by uid 22791); 15 Aug 2007 18:57:30 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 15 Aug 2007 18:57:26 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 538E52AA62B; Wed, 15 Aug 2007 14:57:24 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 085PcyokfN1M; Wed, 15 Aug 2007 14:57:24 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1D1322AA5F8; Wed, 15 Aug 2007 14:57:24 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9DC4BE7B54; Wed, 15 Aug 2007 12:01:10 -0700 (PDT) Date: Wed, 15 Aug 2007 18:57:00 -0000 From: Joel Brobecker To: Jerome Guitton Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/testsuite] backtrace in mixed language application Message-ID: <20070815190110.GI11498@adacore.com> References: <20070810101003.GA33739@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070810101003.GA33739@adacore.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00315.txt.bz2 Hello Jerome, > 2007-08-10 Jerome Guitton > > * gdb.ada/lang_switch/lang_switch.adb: New file. > * gdb.ada/lang_switch/foo.c: Ditto. > * gdb.ada/lang_switch.exp: New testcase. This looks fine to me, save for one little thing: Make sure to add the copyright headers to foo.c and lang_switch.adb as well. That reminds me that we're trying to move to GPLv3, and your patch actually refers to GPLv2. I think it's fine for this patch, we'll fix it later with the rest of the files when we manage to do the transition. But do give this a few days for people to object before you commit. One tiny comment: I would prefer if foo.c followed the GNU coding standards too, so would you mind formatting it so that the function name starts at the beginning of the line? Thanks, -- Joel