Re: Windows DLL support update.

[Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>]

On Tue, Aug 14, 2007 at 01:23:28AM +0100, Pedro Alves wrote:
> Here is the new version of the patch that converts native win32
> debugging to use the new solib-target.c.

I have a few of questions/observations wrt the win32-nat.c changes.

1) Does it still properly handle the "exceptions" that are thrown by
cygwin which must be ignored?  I believe that the most populr source
of complaints about those came from people who were using pthreads
functions.

2) Is there some reason you didn't record the cygwin load/start address
in win32_make_so?  Isn't all of the information you need available when
that function is called?

3) If the answer to the above question is no, then it seems like
cygwin_load_start and cygwin_load_end should be static variables local
to ignore_access_violation_p.  I wonder if that logic should even be
further broken out into its own inside_cygwin(addr) function.

4) I'd prefer it if you dropped the _p from "ignore_access_violation".

Thanks for the patch.

cgf