From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19104 invoked by alias); 14 Aug 2007 12:10:20 -0000 Received: (qmail 19045 invoked by uid 22791); 14 Aug 2007 12:10:19 -0000 X-Spam-Check-By: sourceware.org Received: from pool-72-70-61-242.bstnma.fios.verizon.net (HELO ednor.cgf.cx) (72.70.61.242) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 14 Aug 2007 12:10:11 +0000 Received: by ednor.cgf.cx (Postfix, from userid 201) id 4A4D92B353; Tue, 14 Aug 2007 08:10:09 -0400 (EDT) Date: Tue, 14 Aug 2007 12:10:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org Subject: Re: Windows DLL support update. Message-ID: <20070814121008.GA18838@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org References: <46C0F600.5010607@portugalmail.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46C0F600.5010607@portugalmail.pt> User-Agent: Mutt/1.5.15 (2007-04-06) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00283.txt.bz2 On Tue, Aug 14, 2007 at 01:23:28AM +0100, Pedro Alves wrote: > Here is the new version of the patch that converts native win32 > debugging to use the new solib-target.c. I have a few of questions/observations wrt the win32-nat.c changes. 1) Does it still properly handle the "exceptions" that are thrown by cygwin which must be ignored? I believe that the most populr source of complaints about those came from people who were using pthreads functions. 2) Is there some reason you didn't record the cygwin load/start address in win32_make_so? Isn't all of the information you need available when that function is called? 3) If the answer to the above question is no, then it seems like cygwin_load_start and cygwin_load_end should be static variables local to ignore_access_violation_p. I wonder if that logic should even be further broken out into its own inside_cygwin(addr) function. 4) I'd prefer it if you dropped the _p from "ignore_access_violation". Thanks for the patch. cgf