From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro_alves@portugalmail.pt>
Cc: gdb-patches@sourceware.org
Subject: Re: [gdbserver] Fix toolhelp usage on Windows CE
Date: Tue, 31 Jul 2007 03:01:00 -0000 [thread overview]
Message-ID: <20070731030131.GA18131@caradoc.them.org> (raw)
In-Reply-To: <46AE7420.2020300@portugalmail.pt>
On Tue, Jul 31, 2007 at 12:28:32AM +0100, Pedro Alves wrote:
> Hi,
>
> On Windows CE, the toolhelp functionality is implemented on
> its own dll. Additionally, (and because of the former), the snapshots
> must be closed with a special close
> function - CloseToolhelp32Snapshot - unlike the "desktop" Windows
> versions, which use the standard CloseHandle. The current code isn't
> doing it right. This patch fixes it.
>
> (in case the toolhelp_get_dll_name hunk isn't clear in
> the diff, I'm just 'reorganizing a bit'/'removing the goto'
> to minimize the #ifdefery.)
>
> OK?
OK, thanks.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2007-07-31 3:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 23:34 Pedro Alves
2007-07-31 3:01 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070731030131.GA18131@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro_alves@portugalmail.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox