From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19209 invoked by alias); 31 Jul 2007 03:01:40 -0000 Received: (qmail 19200 invoked by uid 22791); 31 Jul 2007 03:01:39 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 31 Jul 2007 03:01:35 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id CF9D198311; Tue, 31 Jul 2007 03:01:34 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 918D598294; Tue, 31 Jul 2007 03:01:34 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IFhzI-0004mE-4l; Mon, 30 Jul 2007 23:01:32 -0400 Date: Tue, 31 Jul 2007 03:01:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [gdbserver] Fix toolhelp usage on Windows CE Message-ID: <20070731030131.GA18131@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <46AE7420.2020300@portugalmail.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46AE7420.2020300@portugalmail.pt> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00320.txt.bz2 On Tue, Jul 31, 2007 at 12:28:32AM +0100, Pedro Alves wrote: > Hi, > > On Windows CE, the toolhelp functionality is implemented on > its own dll. Additionally, (and because of the former), the snapshots > must be closed with a special close > function - CloseToolhelp32Snapshot - unlike the "desktop" Windows > versions, which use the standard CloseHandle. The current code isn't > doing it right. This patch fixes it. > > (in case the toolhelp_get_dll_name hunk isn't clear in > the diff, I'm just 'reorganizing a bit'/'removing the goto' > to minimize the #ifdefery.) > > OK? OK, thanks. -- Daniel Jacobowitz CodeSourcery