Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFC] lib/mi-support.exp: kill SID inferior prior to reconnecting
@ 2007-07-21  4:29 Kevin Buettner
  2007-07-23 19:02 ` Daniel Jacobowitz
  2007-07-24  1:25 ` Kevin Buettner
  0 siblings, 2 replies; 3+ messages in thread
From: Kevin Buettner @ 2007-07-21  4:29 UTC (permalink / raw)
  To: gdb-patches

Below is another SID related patch.   This patch was motivated by
gdb.mi/mi-var-cp.exp which uses the inline test support in
lib/mi-support.exp.   The first inline test runs okay, but subsequent
tests run into trouble when attempting to reconnect to SID using the
same port as the existing connection.  This patch simply kills (or
attempts to kill) the inferior first to avoid that problem.

Comments?

	* lib/mi-support.exp (mi_gdb_target_load): Do a "kill" prior
	to restarting SID.

Index: testsuite/lib/mi-support.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/mi-support.exp,v
retrieving revision 1.47
diff -u -p -r1.47 mi-support.exp
--- testsuite/lib/mi-support.exp	23 May 2007 12:41:14 -0000	1.47
+++ testsuite/lib/mi-support.exp	19 Jul 2007 00:52:03 -0000
@@ -464,6 +464,10 @@ proc mi_gdb_target_load { } {
 	}
     } elseif { [info procs send_target_sid] != "" } {
 	# For SID, things get complex
+	send_gdb "kill\n"
+	gdb_expect 10 {
+	    -re ".*$mi_gdb_prompt$"
+	}
 	send_target_sid
 	gdb_expect 60 {
 	    -re "\\^done.*$mi_gdb_prompt$" {


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC] lib/mi-support.exp: kill SID inferior prior to  reconnecting
  2007-07-21  4:29 [RFC] lib/mi-support.exp: kill SID inferior prior to reconnecting Kevin Buettner
@ 2007-07-23 19:02 ` Daniel Jacobowitz
  2007-07-24  1:25 ` Kevin Buettner
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Jacobowitz @ 2007-07-23 19:02 UTC (permalink / raw)
  To: Kevin Buettner; +Cc: gdb-patches

On Fri, Jul 20, 2007 at 02:18:02PM -0700, Kevin Buettner wrote:
> Below is another SID related patch.   This patch was motivated by
> gdb.mi/mi-var-cp.exp which uses the inline test support in
> lib/mi-support.exp.   The first inline test runs okay, but subsequent
> tests run into trouble when attempting to reconnect to SID using the
> same port as the existing connection.  This patch simply kills (or
> attempts to kill) the inferior first to avoid that problem.
> 
> Comments?

I've had to do similar things for gdbserver, so I think this is
probably right.

-- 
Daniel Jacobowitz
CodeSourcery


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC] lib/mi-support.exp: kill SID inferior prior to  reconnecting
  2007-07-21  4:29 [RFC] lib/mi-support.exp: kill SID inferior prior to reconnecting Kevin Buettner
  2007-07-23 19:02 ` Daniel Jacobowitz
@ 2007-07-24  1:25 ` Kevin Buettner
  1 sibling, 0 replies; 3+ messages in thread
From: Kevin Buettner @ 2007-07-24  1:25 UTC (permalink / raw)
  To: gdb-patches

On Fri, 20 Jul 2007 14:18:02 -0700
Kevin Buettner <kevinb@redhat.com> wrote:

> 	* lib/mi-support.exp (mi_gdb_target_load): Do a "kill" prior
> 	to restarting SID.

Committed.

Kevin


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-07-23 22:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-21  4:29 [RFC] lib/mi-support.exp: kill SID inferior prior to reconnecting Kevin Buettner
2007-07-23 19:02 ` Daniel Jacobowitz
2007-07-24  1:25 ` Kevin Buettner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox