From: Daniel Jacobowitz <drow@false.org>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Ulrich Weigand <uweigand@de.ibm.com>,
Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [rfc] Remove dead code in breakpoint.c
Date: Sun, 01 Jul 2007 22:35:00 -0000 [thread overview]
Message-ID: <20070701223433.GB337@caradoc.them.org> (raw)
In-Reply-To: <467B9637.4000409@de.ibm.com>
On Fri, Jun 22, 2007 at 11:28:23AM +0200, Markus Deuling wrote:
> Hello,
>
> there is no place where DISABLE_UNSETTABLE_BREAK macro is defined. So I guess
> the code in
> breakpoint.c is dead code. But I'm not sure about this- Is there a situation
> where the removed
> code is used? If so please ignore that patch.
>
> ChangeLog:
>
> * breakpoint.c (insert_bp_location): Remove dead code
> (DISABLE_UNSETTABLE_BREAK).
> (disable_breakpoints_in_shlibs)
> (disable_breakpoints_in_unloaded_shlib): Likewise (comment).
>
> Is this ok ?
Yes, this is OK. Thanks.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-07-01 22:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 9:30 Markus Deuling
2007-07-01 22:35 ` Daniel Jacobowitz [this message]
2007-07-02 18:34 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070701223433.GB337@caradoc.them.org \
--to=drow@false.org \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox