Re: Disassemble branch delay slot instructions automatically

[Daniel Jacobowitz <drow@false.org>]

On Wed, Jun 20, 2007 at 02:56:20PM +0100, Maciej W. Rozycki wrote:
> On Wed, 13 Jun 2007, Daniel Jacobowitz wrote:
> 
> > I think the patch is pretty much OK, except for the use of
> > TARGET_PRINT_INSN.  We're trying to eliminate the gdbarch macros now.
> > I think the best solution would be to add the extra argument to
> > gdb_print_insn; it's only used here and in the TUI.
> 
>  And also in Insight; I have updated that too.  I suppose the plan is to 
> substitute TARGET_PRINT_INSN with gdbarch_print_insn(), but that should be 
> done separately, so that it is not mixed with functional changes.

In fact, it happened yesterday.

2007-06-19  Markus Deuling  <deuling@de.ibm.com>

        * gdbarch.sh (TARGET_PRINT_INSN): Replace by
	gdbarch_print_insn.
        * disasm.c (dump_insns, gdb_print_insn): Likewise.
        * gdbarch.c, gdbarch.h: Regenerate.

So I imagine you need to refresh this patch.  I was actually
suggesting you add the disassemble_info argument to gdb_print_insn,
not the number of delay slots; but this way seems fine too.

This version is OK, if Eli likes the NEWS entry and you add a
Makefile.in update (since you added #include's).  Eli, is the below
OK?

> Index: binutils-quilt/src/gdb/NEWS
> ===================================================================
> --- binutils-quilt.orig/src/gdb/NEWS	2007-06-19 12:24:32.000000000 +0100
> +++ binutils-quilt/src/gdb/NEWS	2007-06-19 15:16:19.000000000 +0100
> @@ -41,6 +41,9 @@
>  layout.  It also supports a TextSeg= and DataSeg= response when only
>  segment base addresses (rather than offsets) are available.
>  
> +* The /i format now outputs any trailing branch delay slot instructions 
> +immediately following the last instruction within the count specified.
> +
>  * New commands
>  
>  set remoteflow
> 

-- 
Daniel Jacobowitz
CodeSourcery