From: Daniel Jacobowitz <drow@false.org>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: gdb-patches@sourceware.org, Nigel Stephens <nigel@mips.com>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: Disassemble branch delay slot instructions automatically
Date: Wed, 13 Jun 2007 16:56:00 -0000 [thread overview]
Message-ID: <20070613165622.GA1023@caradoc.them.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0705181625420.28428@perivale.mips.com>
On Fri, May 18, 2007 at 04:46:55PM +0100, Maciej W. Rozycki wrote:
> On Wed, 16 May 2007, Daniel Jacobowitz wrote:
>
> > I would like additional opinions on this patch.
>
> I wouldn't mind either.
Well, we didn't get any.
I think the patch is pretty much OK, except for the use of
TARGET_PRINT_INSN. We're trying to eliminate the gdbarch macros now.
I think the best solution would be to add the extra argument to
gdb_print_insn; it's only used here and in the TUI.
Why did you need the new function that modified an existing
disassemble_info, instead of using the existing one?
This probably deserves a NEWS entry.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-06-13 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 18:13 Maciej W. Rozycki
2007-05-16 15:32 ` Daniel Jacobowitz
2007-05-18 15:47 ` Maciej W. Rozycki
2007-06-13 16:56 ` Daniel Jacobowitz [this message]
2007-06-20 13:56 ` Maciej W. Rozycki
2007-06-20 14:09 ` Daniel Jacobowitz
2007-06-20 15:25 ` Maciej W. Rozycki
2007-06-20 18:37 ` Eli Zaretskii
2007-06-21 15:19 ` Maciej W. Rozycki
2007-06-21 19:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070613165622.GA1023@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=macro@linux-mips.org \
--cc=macro@mips.com \
--cc=nigel@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox