From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: deuling@de.ibm.com
Cc: gdb-patches@sourceware.org, uweigand@de.ibm.com
Subject: Re: [rfc] Remove macro DEPRECATED_FUNCTION_START_OFFSET
Date: Fri, 15 Jun 2007 20:56:00 -0000 [thread overview]
Message-ID: <200706152055.l5FKtu2q032035@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <46703FA7.1030707@de.ibm.com> (message from Markus Deuling on Wed, 13 Jun 2007 21:04:07 +0200)
> Date: Wed, 13 Jun 2007 21:04:07 +0200
> From: Markus Deuling <deuling@de.ibm.com>
>
> Hello,
>
> this patch completely removes macro
> DEPRECATED_FUNCTION_START_OFFSET. This macro is deprecated and was
> replaced by gdbarch_convert_from_func_ptr_addr. Build and test on
> x86. Testsuite showed no regression.
>
> ChangeLog:
> * gdbarch.sh (DEPRECATED_FUNCTION_START_OFFSET): Remove.
> * cli/cli-cmds.ci (disassemble_command): Replace
> DEPRECATED_FUNCTION_START_OFFSET by gdbarch_convert_from_func_ptr_addr.
> * symtab.c (skip_prologue_using_sal,find_function_start_sal): Likewise.
> * linespec.c (minsym_found): Likewise.
> (target.h): New include.
> * infrun.c (handle_inferior_event): Likewise.
> * infcall.c (find_function_addr): Likewise.
> * Makefile.in (linespec.o): Update dependency to target.h.
> * gdbarch.c, gdbarch.h: Regenerate.
>
> Is this ok to commit?
Unfortunately it is not, since it breaks vax.
gdbarch_convert_from_func_ptr_addr() is not equivalent to
DEPRECATED_FUNCTION_START_OFFSET, since the former is applied in
places where the latter isn't.
prev parent reply other threads:[~2007-06-15 20:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-13 19:05 Markus Deuling
2007-06-13 19:11 ` Daniel Jacobowitz
2007-06-15 20:56 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706152055.l5FKtu2q032035@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox