From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-49427-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10157 invoked by alias); 15 Jun 2007 20:56:03 -0000
Received: (qmail 10149 invoked by uid 22791); 15 Jun 2007 20:56:03 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 15 Jun 2007 20:56:01 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.0/8.14.0) with ESMTP id l5FKtu84002199; 	Fri, 15 Jun 2007 22:55:56 +0200 (CEST)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.0/8.14.0/Submit) id l5FKtu2q032035; 	Fri, 15 Jun 2007 22:55:56 +0200 (CEST)
Date: Fri, 15 Jun 2007 20:56:00 -0000
Message-Id: <200706152055.l5FKtu2q032035@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: deuling@de.ibm.com
CC: gdb-patches@sourceware.org, uweigand@de.ibm.com
In-reply-to: <46703FA7.1030707@de.ibm.com> (message from Markus Deuling on 	Wed, 13 Jun 2007 21:04:07 +0200)
Subject: Re: [rfc] Remove macro DEPRECATED_FUNCTION_START_OFFSET
References:  <46703FA7.1030707@de.ibm.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-06/txt/msg00300.txt.bz2

> Date: Wed, 13 Jun 2007 21:04:07 +0200
> From: Markus Deuling <deuling@de.ibm.com>
> 
> Hello,
> 
> this patch completely removes macro
> DEPRECATED_FUNCTION_START_OFFSET. This macro is deprecated and was
> replaced by gdbarch_convert_from_func_ptr_addr. Build and test on
> x86. Testsuite showed no regression.
> 
> ChangeLog:
> 	* gdbarch.sh (DEPRECATED_FUNCTION_START_OFFSET): Remove.
> 	* cli/cli-cmds.ci (disassemble_command): Replace
> 	DEPRECATED_FUNCTION_START_OFFSET by gdbarch_convert_from_func_ptr_addr.
> 	* symtab.c (skip_prologue_using_sal,find_function_start_sal): Likewise.
> 	* linespec.c (minsym_found): Likewise.
> 	(target.h): New include.
> 	* infrun.c (handle_inferior_event): Likewise.
> 	* infcall.c (find_function_addr): Likewise.
> 	* Makefile.in (linespec.o): Update dependency to target.h.
> 	* gdbarch.c, gdbarch.h: Regenerate.
> 
> Is this ok to commit?

Unfortunately it is not, since it breaks vax.
gdbarch_convert_from_func_ptr_addr() is not equivalent to
DEPRECATED_FUNCTION_START_OFFSET, since the former is applied in
places where the latter isn't.