use execvp() rather than execv() in gdbserver

use execvp() rather than execv() in gdbserver

[Mike Frysinger]

[-- Attachment #1.1: Type: text/plain, Size: 404 bytes --]

is there a compelling reason that execv() is used rather than execvp() in 
gdbserver/linux-low.c ?  seems it's just always been that way ...

personally, i find it annoying having to do:
# gdbserver :1234 /bin/ls /
on my embedded board instead of:
# gdbserver :1234 ls /

having used native gdb a lot more, i typo this pretty often since gdb will 
search $PATH for the program to run ;(
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

[-- Attachment #2: gdbserver-use-execvp.patch --]
[-- Type: text/x-diff, Size: 389 bytes --]

2007-06-12  Mike Frysinger  <vapier@gentoo.org>

	* linux-low.c (linux_create_inferior): Change execv to execvp.

--- linux-low.c
+++ linux-low.c
@@ -165,7 +165,7 @@ linux_create_inferior (char *program, ch
 
       setpgid (0, 0);
 
-      execv (program, allargs);
+      execvp (program, allargs);
 
       fprintf (stderr, "Cannot exec %s: %s.\n", program,
 	       strerror (errno));

Re: use execvp() rather than execv() in gdbserver

[Daniel Jacobowitz]

On Tue, Jun 12, 2007 at 08:08:07PM -0400, Mike Frysinger wrote:
> 2007-06-12  Mike Frysinger  <vapier@gentoo.org>
> 
> 	* linux-low.c (linux_create_inferior): Change execv to execvp.

Fine with me.  Should you have write access?

-- 
Daniel Jacobowitz
CodeSourcery

Re: use execvp() rather than execv() in gdbserver

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

On Wednesday 13 June 2007, Daniel Jacobowitz wrote:
> On Tue, Jun 12, 2007 at 08:08:07PM -0400, Mike Frysinger wrote:
> > 2007-06-12  Mike Frysinger  <vapier@gentoo.org>
> >
> > 	* linux-low.c (linux_create_inferior): Change execv to execvp.
>
> Fine with me.  Should you have write access?

i dont think ADI has the legal papers in place yet with the gdb guys ...
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

Re: use execvp() rather than execv() in gdbserver

[Daniel Jacobowitz]

On Wed, Jun 13, 2007 at 05:00:14PM -0400, Mike Frysinger wrote:
> On Wednesday 13 June 2007, Daniel Jacobowitz wrote:
> > On Tue, Jun 12, 2007 at 08:08:07PM -0400, Mike Frysinger wrote:
> > > 2007-06-12  Mike Frysinger  <vapier@gentoo.org>
> > >
> > > 	* linux-low.c (linux_create_inferior): Change execv to execvp.
> >
> > Fine with me.  Should you have write access?
> 
> i dont think ADI has the legal papers in place yet with the gdb guys ...
> -mike

Oh right.  Well, this is obvious, so I checked it in for you.  I did
SPU too.

-- 
Daniel Jacobowitz
CodeSourcery