Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: drow@false.org (Daniel Jacobowitz)
Cc: gdb-patches@sourceware.org, eliz@gnu.org
Subject: Re: [rfc/rfa] [3/4] SPU enhancements: gdbserver support
Date: Tue, 12 Jun 2007 14:43:00 -0000	[thread overview]
Message-ID: <200706121443.l5CEhdhb011752@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20070612135822.GE7815@caradoc.them.org> from "Daniel Jacobowitz" at Jun 12, 2007 09:58:22 AM

Daniel Jacobowitz wrote:
> On Wed, Jun 06, 2007 at 01:02:31AM +0200, Ulrich Weigand wrote:
> > Daniel Jacobowitz wrote:
> > > On Mon, Jun 04, 2007 at 04:09:56PM -0400, Daniel Jacobowitz wrote:
> > > > On Mon, Jun 04, 2007 at 10:05:01PM +0200, Ulrich Weigand wrote:
> > > > > Fine with me.  I'd appreciate if you could post that code ...
> > > > 
> > > > I'll try to do this tomorrow morning.
> > > 
> > > There's not as much code for it as I remembered.
> > 
> > Thanks.  It looks like the require_data routine you posted is nearly
> > identical to the already existing remote_unescape_input routine, so
> > I just used that one.
> > 
> > The patch below should address both issues you raised.  OK?
> 
> Yes, this version is fine with me.  Thanks.

Thanks for the review!  I've committed this version now.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


      reply	other threads:[~2007-06-12 14:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-02 19:33 Ulrich Weigand
2007-06-02 20:33 ` Eli Zaretskii
2007-06-03 13:28   ` Ulrich Weigand
2007-06-03 16:44     ` Eli Zaretskii
2007-06-04 13:58       ` Ulrich Weigand
2007-06-04 19:19         ` Eli Zaretskii
2007-06-04 20:02           ` Ulrich Weigand
2007-06-04 19:54 ` Daniel Jacobowitz
2007-06-04 20:05   ` Ulrich Weigand
2007-06-04 20:10     ` Daniel Jacobowitz
2007-06-05 18:34       ` Daniel Jacobowitz
2007-06-05 23:02         ` Ulrich Weigand
2007-06-06 17:51           ` Eli Zaretskii
2007-06-12 13:58           ` Daniel Jacobowitz
2007-06-12 14:43             ` Ulrich Weigand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706121443.l5CEhdhb011752@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox