From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26591 invoked by alias); 12 Jun 2007 14:43:46 -0000 Received: (qmail 26582 invoked by uid 22791); 12 Jun 2007 14:43:45 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 12 Jun 2007 14:43:43 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5CEheE6097136 for ; Tue, 12 Jun 2007 14:43:40 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5CEheZS4042840 for ; Tue, 12 Jun 2007 16:43:40 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5CEhdbu011755 for ; Tue, 12 Jun 2007 16:43:40 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l5CEhdhb011752; Tue, 12 Jun 2007 16:43:39 +0200 Message-Id: <200706121443.l5CEhdhb011752@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 12 Jun 2007 16:43:39 +0200 Subject: Re: [rfc/rfa] [3/4] SPU enhancements: gdbserver support To: drow@false.org (Daniel Jacobowitz) Date: Tue, 12 Jun 2007 14:43:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, eliz@gnu.org In-Reply-To: <20070612135822.GE7815@caradoc.them.org> from "Daniel Jacobowitz" at Jun 12, 2007 09:58:22 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00170.txt.bz2 Daniel Jacobowitz wrote: > On Wed, Jun 06, 2007 at 01:02:31AM +0200, Ulrich Weigand wrote: > > Daniel Jacobowitz wrote: > > > On Mon, Jun 04, 2007 at 04:09:56PM -0400, Daniel Jacobowitz wrote: > > > > On Mon, Jun 04, 2007 at 10:05:01PM +0200, Ulrich Weigand wrote: > > > > > Fine with me. I'd appreciate if you could post that code ... > > > > > > > > I'll try to do this tomorrow morning. > > > > > > There's not as much code for it as I remembered. > > > > Thanks. It looks like the require_data routine you posted is nearly > > identical to the already existing remote_unescape_input routine, so > > I just used that one. > > > > The patch below should address both issues you raised. OK? > > Yes, this version is fine with me. Thanks. Thanks for the review! I've committed this version now. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com