Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: gdb-patches@sourceware.org
Subject: [rfc][0/13] Eliminate read_register et al
Date: Thu, 07 Jun 2007 20:56:00 -0000	[thread overview]
Message-ID: <200706072056.l57KucXB019012@d12av02.megacenter.de.ibm.com> (raw)

Hello,

the following patch set eliminates the routines read_register, 
read_register_pid, write_register, and write_register_pid, including
all their callers.  This is the next step towards removing the
current_regcache global variable.

The patch set consists of 13 parts:

First some special read_register et al uses:
[1/13] write_register in solib-sunos.c
[2/13] read_register in cris/frv_stopped_data_address
[3/13] read_register in mep-tdep.c current_ routines
[4/13] read_register in deprecated_mips_set_processor_regs_hack
[5/13] read_register in sh_show_regs_command
[6/13] read_register (invalidly) used in prologue analyzers

Then more general classes of uses:
[7/13] Uses that are already unnecessary
[8/13] Uses in software_single_step callbacks
[9/13] Uses in skip_trampoline callbacks
[10/13] Uses in get_longjmp_target callbacks
[11/13] Uses in push_dummy_code callbacks
[12/13] Uses in read_pc / write_pc callbacks

And finally:
[13/13] Remove definition

I'd appreciate any comments; in particular some the areas touched by
the first set of patches could probably need a more general cleanup
anyway ...


I've tested the full patch set natively on:
powerpc64-linux
powerpc-ibm-aix5.3.0.0
spu-elf
s390-ibm-linux
s390x-ibm-linux
i386-linux
ia64-linux

and on the simulator for:
arm-elf
mips-elf
sh-elf
v850-elf

Architectures touched but untested as I have neither native
hardware nor a working (toolchain or) simulator:
alpha
amd64
avr
cris
frv
m32c
m32r
m68hc11
m68k
m88k
mep
mn10300
sparc
xstormy16

Additional testers would certainly be welcome!


In addition, tested by running gdb-mbuild.sh and making sure every
file touched by the patch set still builds.


Any opinions?  Should I proceed with this patch set?

Thanks,
Ulrich


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


             reply	other threads:[~2007-06-07 20:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-07 20:56 Ulrich Weigand [this message]
2007-06-08 17:15 ` Joel Brobecker
2007-06-08 23:25   ` Ulrich Weigand
2007-06-14  1:29     ` Joel Brobecker
2007-06-14 11:13       ` Ulrich Weigand
2007-06-14 17:07         ` Joel Brobecker
2007-06-14 17:09           ` Ulrich Weigand
2007-06-14 18:46             ` Joel Brobecker
2007-06-14 19:45               ` Ulrich Weigand
2007-06-15 22:51 ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706072056.l57KucXB019012@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox