From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29838 invoked by alias); 7 Jun 2007 20:56:45 -0000 Received: (qmail 29829 invoked by uid 22791); 7 Jun 2007 20:56:45 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate8.de.ibm.com (HELO mtagate8.de.ibm.com) (195.212.29.157) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 07 Jun 2007 20:56:41 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.13.8/8.13.8) with ESMTP id l57Kuc6K331710 for ; Thu, 7 Jun 2007 20:56:38 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l57KucBK3776638 for ; Thu, 7 Jun 2007 22:56:38 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l57Kucuv019015 for ; Thu, 7 Jun 2007 22:56:38 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l57KucXB019012 for ; Thu, 7 Jun 2007 22:56:38 +0200 Message-Id: <200706072056.l57KucXB019012@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 7 Jun 2007 22:56:38 +0200 Subject: [rfc][0/13] Eliminate read_register et al To: gdb-patches@sourceware.org Date: Thu, 07 Jun 2007 20:56:00 -0000 From: "Ulrich Weigand" X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00079.txt.bz2 Hello, the following patch set eliminates the routines read_register, read_register_pid, write_register, and write_register_pid, including all their callers. This is the next step towards removing the current_regcache global variable. The patch set consists of 13 parts: First some special read_register et al uses: [1/13] write_register in solib-sunos.c [2/13] read_register in cris/frv_stopped_data_address [3/13] read_register in mep-tdep.c current_ routines [4/13] read_register in deprecated_mips_set_processor_regs_hack [5/13] read_register in sh_show_regs_command [6/13] read_register (invalidly) used in prologue analyzers Then more general classes of uses: [7/13] Uses that are already unnecessary [8/13] Uses in software_single_step callbacks [9/13] Uses in skip_trampoline callbacks [10/13] Uses in get_longjmp_target callbacks [11/13] Uses in push_dummy_code callbacks [12/13] Uses in read_pc / write_pc callbacks And finally: [13/13] Remove definition I'd appreciate any comments; in particular some the areas touched by the first set of patches could probably need a more general cleanup anyway ... I've tested the full patch set natively on: powerpc64-linux powerpc-ibm-aix5.3.0.0 spu-elf s390-ibm-linux s390x-ibm-linux i386-linux ia64-linux and on the simulator for: arm-elf mips-elf sh-elf v850-elf Architectures touched but untested as I have neither native hardware nor a working (toolchain or) simulator: alpha amd64 avr cris frv m32c m32r m68hc11 m68k m88k mep mn10300 sparc xstormy16 Additional testers would certainly be welcome! In addition, tested by running gdb-mbuild.sh and making sure every file touched by the patch set still builds. Any opinions? Should I proceed with this patch set? Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com