From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: deuling@de.ibm.com (Markus Deuling)
Cc: gdb-patches@sourceware.org (GDB Patches)
Subject: Re: [rfc] [1/9] Remove macro REGISTER_NAME
Date: Wed, 06 Jun 2007 15:17:00 -0000 [thread overview]
Message-ID: <200706061517.l56FH0IE009064@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <46600578.2040607@de.ibm.com> from "Markus Deuling" at Jun 01, 2007 01:39:36 PM
Markus Deuling wrote:
> this patch removes REGISTER_NAME macro from gdbarch.sh
Look good except for some minor formatting issues:
* sh64-tdep.c (sh64_do_fp_register,sh64_do_register)
Should have space after comma (throughout the ChangeLog).
+ if (gdbarch_register_name (current_gdbarch, regnum) == NULL
+ || *gdbarch_register_name (current_gdbarch, (regnum)) == '\0')
Parentheses around "regnum" are unnecessary.
+ gdbarch_register_name
+ (current_gdbarch, argreg),
I think convention is to indent the argument list by two space
if it starts completely on a new line ...
+ gdbarch_register_name (current_gdbarch,
+ DWARF2_REG_TO_REGNUM(reg)),
Indentation is quite odd here...
+ gdb_assert (gdbarch_register_name (current_gdbarch,
+ VALUE_REGNUM (lazy_value)) != NULL
+ && *gdbarch_register_name
+ (current_gdbarch, VALUE_REGNUM (lazy_value)) != '\0');
And here.
+ print_spaces_filtered (15 - strlen (gdbarch_register_name
+ (current_gdbarch,i)), file);
Indentation. Space after comma.
+ ui_out_field_string (uiout, NULL,
+ gdbarch_register_name
+ (current_gdbarch, regnum));
Indentation.
+ fprintf_filtered (file, "%*s", 4 - (int) strlen (gdbarch_register_name
+ (current_gdbarch, regnum)),
Indentation.
+ if (gdbarch_register_name (current_gdbarch,
+ gdbarch_num_regs (current_gdbarch) + regnum)
+ != NULL
+ && gdbarch_register_name (current_gdbarch,
+ gdbarch_num_regs (current_gdbarch) + regnum)[0]
+ != '\0')
Indentation
frame_register_read (frame, regnum, buff);
+ fputs_filtered (gdbarch_register_name (current_gdbarch, regnum), file);
+ print_spaces_filtered (15 - strlen (gdbarch_register_name
+ (current_gdbarch, regnum)), file);
Indentation.
+ fputs_filtered (gdbarch_register_name (current_gdbarch, regnum), file);
+ print_spaces_filtered (15 - strlen (gdbarch_register_name
+ (current_gdbarch, regnum)), file);
Again.
+ fprintf_unfiltered (gdb_stdlog, "(%s)", gdbarch_register_name
+ (current_gdbarch, regno));
Again.
+ gdbarch_register_name
+ (current_gdbarch, SYMBOL_VALUE (sym)));
Again.
+ gdbarch_register_name
+ (current_gdbarch, SYMBOL_VALUE (sym)));
Again.
+ gdbarch_register_name
+ (current_gdbarch, SYMBOL_VALUE (sym)));
Again.
+ gdbarch_register_name
+ (current_gdbarch, SYMBOL_BASEREG (sym)));
Again.
+ gdbarch_register_name
+ (current_gdbarch, SYMBOL_BASEREG (sym)));
Again.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2007-06-06 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 11:41 Markus Deuling
2007-06-06 15:17 ` Ulrich Weigand [this message]
2007-06-08 6:28 ` Markus Deuling
2007-06-09 13:44 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706061517.l56FH0IE009064@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox