From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12276 invoked by alias); 6 Jun 2007 15:17:12 -0000 Received: (qmail 12262 invoked by uid 22791); 6 Jun 2007 15:17:12 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 06 Jun 2007 15:17:04 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id l56FH1gG557136 for ; Wed, 6 Jun 2007 15:17:01 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l56FH08l4005988 for ; Wed, 6 Jun 2007 17:17:00 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l56FH0bE009068 for ; Wed, 6 Jun 2007 17:17:00 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l56FH0IE009064; Wed, 6 Jun 2007 17:17:00 +0200 Message-Id: <200706061517.l56FH0IE009064@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 6 Jun 2007 17:17:00 +0200 Subject: Re: [rfc] [1/9] Remove macro REGISTER_NAME To: deuling@de.ibm.com (Markus Deuling) Date: Wed, 06 Jun 2007 15:17:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <46600578.2040607@de.ibm.com> from "Markus Deuling" at Jun 01, 2007 01:39:36 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00060.txt.bz2 Markus Deuling wrote: > this patch removes REGISTER_NAME macro from gdbarch.sh Look good except for some minor formatting issues: * sh64-tdep.c (sh64_do_fp_register,sh64_do_register) Should have space after comma (throughout the ChangeLog). + if (gdbarch_register_name (current_gdbarch, regnum) == NULL + || *gdbarch_register_name (current_gdbarch, (regnum)) == '\0') Parentheses around "regnum" are unnecessary. + gdbarch_register_name + (current_gdbarch, argreg), I think convention is to indent the argument list by two space if it starts completely on a new line ... + gdbarch_register_name (current_gdbarch, + DWARF2_REG_TO_REGNUM(reg)), Indentation is quite odd here... + gdb_assert (gdbarch_register_name (current_gdbarch, + VALUE_REGNUM (lazy_value)) != NULL + && *gdbarch_register_name + (current_gdbarch, VALUE_REGNUM (lazy_value)) != '\0'); And here. + print_spaces_filtered (15 - strlen (gdbarch_register_name + (current_gdbarch,i)), file); Indentation. Space after comma. + ui_out_field_string (uiout, NULL, + gdbarch_register_name + (current_gdbarch, regnum)); Indentation. + fprintf_filtered (file, "%*s", 4 - (int) strlen (gdbarch_register_name + (current_gdbarch, regnum)), Indentation. + if (gdbarch_register_name (current_gdbarch, + gdbarch_num_regs (current_gdbarch) + regnum) + != NULL + && gdbarch_register_name (current_gdbarch, + gdbarch_num_regs (current_gdbarch) + regnum)[0] + != '\0') Indentation frame_register_read (frame, regnum, buff); + fputs_filtered (gdbarch_register_name (current_gdbarch, regnum), file); + print_spaces_filtered (15 - strlen (gdbarch_register_name + (current_gdbarch, regnum)), file); Indentation. + fputs_filtered (gdbarch_register_name (current_gdbarch, regnum), file); + print_spaces_filtered (15 - strlen (gdbarch_register_name + (current_gdbarch, regnum)), file); Again. + fprintf_unfiltered (gdb_stdlog, "(%s)", gdbarch_register_name + (current_gdbarch, regno)); Again. + gdbarch_register_name + (current_gdbarch, SYMBOL_VALUE (sym))); Again. + gdbarch_register_name + (current_gdbarch, SYMBOL_VALUE (sym))); Again. + gdbarch_register_name + (current_gdbarch, SYMBOL_VALUE (sym))); Again. + gdbarch_register_name + (current_gdbarch, SYMBOL_BASEREG (sym))); Again. + gdbarch_register_name + (current_gdbarch, SYMBOL_BASEREG (sym))); Again. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com