From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Remove register_bytes_ok arch method
Date: Mon, 14 May 2007 17:46:00 -0000 [thread overview]
Message-ID: <20070514174607.GG4818@caradoc.them.org> (raw)
In-Reply-To: <200705051226.32219.vladimir@codesourcery.com>
On Sat, May 05, 2007 at 12:26:31PM +0400, Vladimir Prus wrote:
>
> At the moment, the register_bytes_ok arch method is defined
> only by m68k-tdep.c. There's no good reason to have this method now,
> as remote.c, if it does not see some register in 'g' reply will send
> extra 'p' reply just fine. Further, it's hard to decide what's
> right size of 'g' reply -- target may have floating point registers, or
> might not have, and so on.
>
> This patch removes register_bytes_ok arch method. OK?
I agree. The patch is OK, but you didn't remove it right. gdbarch.h
and gdbarch.c are generated by running gdbarch.sh; just remove it from
there, run the script, and move the new files into place.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-05-14 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-05 8:26 Vladimir Prus
2007-05-14 17:46 ` Daniel Jacobowitz [this message]
2007-05-28 11:41 ` Vladimir Prus
2007-06-05 15:20 ` Daniel Jacobowitz
2007-06-06 19:42 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070514174607.GG4818@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox