From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14413 invoked by alias); 14 May 2007 17:46:22 -0000 Received: (qmail 14405 invoked by uid 22791); 14 May 2007 17:46:21 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 14 May 2007 17:46:18 +0000 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 26AFB4B267; Mon, 14 May 2007 12:46:17 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 4AC054B262; Mon, 14 May 2007 12:46:08 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1HnecZ-00029B-Sn; Mon, 14 May 2007 13:46:07 -0400 Date: Mon, 14 May 2007 17:46:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: Remove register_bytes_ok arch method Message-ID: <20070514174607.GG4818@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200705051226.32219.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705051226.32219.vladimir@codesourcery.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00248.txt.bz2 On Sat, May 05, 2007 at 12:26:31PM +0400, Vladimir Prus wrote: > > At the moment, the register_bytes_ok arch method is defined > only by m68k-tdep.c. There's no good reason to have this method now, > as remote.c, if it does not see some register in 'g' reply will send > extra 'p' reply just fine. Further, it's hard to decide what's > right size of 'g' reply -- target may have floating point registers, or > might not have, and so on. > > This patch removes register_bytes_ok arch method. OK? I agree. The patch is OK, but you didn't remove it right. gdbarch.h and gdbarch.c are generated by running gdbarch.sh; just remove it from there, run the script, and move the new files into place. -- Daniel Jacobowitz CodeSourcery