From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Eliminate write_register from solib-sunos.c
Date: Sun, 13 May 2007 23:55:00 -0000 [thread overview]
Message-ID: <20070513235530.GA18059@caradoc.them.org> (raw)
In-Reply-To: <200705120031.l4C0VDqg010367@d12av02.megacenter.de.ibm.com>
On Sat, May 12, 2007 at 02:31:13AM +0200, Ulrich Weigand wrote:
> Hello,
>
> solib-sunos.c has a place where it adjusts the PC by DECR_PC_AFTER_BREAK.
> Unlike all other places to do so, it uses write_register (PC_REGNUM ...).
>
> As I'm trying to eliminate write_register, I'd like to get rid of this.
> The following patch replaces the write_register call by write_pc.
>
> Is this OK?
I noticed this call last week. I'm not sure if any platform using
solib-sunos.c even triggers it... but if they do, I think it's
decrementing the PC twice. Didn't infrun take care of it?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-05-13 23:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-12 0:31 Ulrich Weigand
2007-05-13 23:55 ` Daniel Jacobowitz [this message]
2007-05-14 15:01 ` Ulrich Weigand
2007-05-14 15:15 ` Mark Kettenis
2007-05-14 20:53 ` Ulrich Weigand
2007-06-04 18:53 ` Ulrich Weigand
2007-06-15 16:46 ` Mark Kettenis
2007-06-15 16:58 ` Ulrich Weigand
2007-06-15 21:22 ` Mark Kettenis
2007-06-15 21:28 ` Daniel Jacobowitz
2007-06-15 22:13 ` Ulrich Weigand
2007-05-14 15:21 ` Daniel Jacobowitz
2007-05-14 20:28 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070513235530.GA18059@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox