From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26500 invoked by alias); 13 May 2007 23:55:37 -0000 Received: (qmail 26466 invoked by uid 22791); 13 May 2007 23:55:36 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 13 May 2007 23:55:34 +0000 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 340AF4B267; Sun, 13 May 2007 18:55:32 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 15DDC4B262; Sun, 13 May 2007 18:55:31 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1HnNuU-0004m9-UB; Sun, 13 May 2007 19:55:31 -0400 Date: Sun, 13 May 2007 23:55:00 -0000 From: Daniel Jacobowitz To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfc] Eliminate write_register from solib-sunos.c Message-ID: <20070513235530.GA18059@caradoc.them.org> Mail-Followup-To: Ulrich Weigand , gdb-patches@sourceware.org References: <200705120031.l4C0VDqg010367@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705120031.l4C0VDqg010367@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00226.txt.bz2 On Sat, May 12, 2007 at 02:31:13AM +0200, Ulrich Weigand wrote: > Hello, > > solib-sunos.c has a place where it adjusts the PC by DECR_PC_AFTER_BREAK. > Unlike all other places to do so, it uses write_register (PC_REGNUM ...). > > As I'm trying to eliminate write_register, I'd like to get rid of this. > The following patch replaces the write_register call by write_pc. > > Is this OK? I noticed this call last week. I'm not sure if any platform using solib-sunos.c even triggers it... but if they do, I think it's decrementing the PC twice. Didn't infrun take care of it? -- Daniel Jacobowitz CodeSourcery