Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc / remote protocol] Remote shared library events
Date: Fri, 11 May 2007 17:24:00 -0000	[thread overview]
Message-ID: <20070511172428.GA22529@caradoc.them.org> (raw)
In-Reply-To: <ubqgt1i4a.fsf@gnu.org>

On Thu, May 10, 2007 at 06:18:29AM +0300, Eli Zaretskii wrote:
> > +@item
> > +If @var{n} is @samp{load}, then the packet indicates a DLL load event,
> > +and @var{r} describes the newly loaded library.  The library format is
> > +the same used in @samp{qfDllInfo} replies (@pxref{qfDllInfo}), e.g.@:
> > +@samp{load:Name=@var{hexname},TextSeg=@var{textaddr}}.  The entry may
> > +end in @samp{,nop} if this library was already mapped, e.g.@: by an
> > +earlier call to @code{LoadLibrary}.  @var{aa} should be @samp{05}, the
> > +trap signal.
> 
> I think we need to explain what is ``hexname'' here, unless it is
> already used and explained in the preceding portion of this section.

It's explained at the target of the @pxref, where TextSeg and textaddr
are also; is that OK?

> Also, should we have some index entries here?

Yep.

> > +until the target responds with @samp{l} (lower-case el, for
>                                                        ^^
> I believe the letter's name is ``ell''.

"In reference, it is spelled el or ell." says Wikipedia; I actually
copied this from a few lines further down in the manual.  If there's
some reason to change el -> ell let me know and I'll do it consistently.

> > +Reply:
> > +@table @samp
> > +@item m Name=@var{hexname},TextSeg=@var{textaddr}@r{[},DataSeg=@var{dataaddr}@r{]}
> 
> Does this long line look good in print?

Yes, it seems to be OK; it's less than half the print area wide in the PDF.

> > +@item m @var{library}; @var{library}@dots{} @r{[}; l@r{[}
> 
> Did you really mean two left [ brackets here?

Whoops!  I'll have updated documentation in the revised patch, due soon.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-05-11 17:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-09 20:16 Daniel Jacobowitz
2007-05-10  3:18 ` Eli Zaretskii
2007-05-11 17:24   ` Daniel Jacobowitz [this message]
2007-05-11 17:39     ` Eli Zaretskii
2007-05-10 21:35 ` Mark Kettenis
2007-05-11  3:35   ` Daniel Jacobowitz
2007-05-15 13:28   ` Daniel Jacobowitz
2007-05-21 12:00     ` Daniel Jacobowitz
2007-07-02 21:37     ` Daniel Jacobowitz
2007-05-11 18:02 ` Kevin Buettner
2007-05-11 18:21   ` Daniel Jacobowitz
2007-05-11 23:31 ` Pedro Alves
2007-05-16 22:59 ` Jim Blandy
2007-05-18  0:27   ` Daniel Jacobowitz
2007-05-18 16:04     ` Jim Blandy
2007-05-18 16:10       ` Daniel Jacobowitz
2007-05-18 16:49         ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070511172428.GA22529@caradoc.them.org \
    --to=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox