From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18179 invoked by alias); 11 May 2007 17:24:43 -0000 Received: (qmail 18169 invoked by uid 22791); 11 May 2007 17:24:42 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 11 May 2007 17:24:38 +0000 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 3E7064B267; Fri, 11 May 2007 12:24:35 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 04BD94B262; Fri, 11 May 2007 12:24:29 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1HmYqy-0006DV-Iz; Fri, 11 May 2007 13:24:28 -0400 Date: Fri, 11 May 2007 17:24:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [rfc / remote protocol] Remote shared library events Message-ID: <20070511172428.GA22529@caradoc.them.org> Mail-Followup-To: Eli Zaretskii , gdb-patches@sourceware.org References: <20070509201627.GA23422@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00187.txt.bz2 On Thu, May 10, 2007 at 06:18:29AM +0300, Eli Zaretskii wrote: > > +@item > > +If @var{n} is @samp{load}, then the packet indicates a DLL load event, > > +and @var{r} describes the newly loaded library. The library format is > > +the same used in @samp{qfDllInfo} replies (@pxref{qfDllInfo}), e.g.@: > > +@samp{load:Name=@var{hexname},TextSeg=@var{textaddr}}. The entry may > > +end in @samp{,nop} if this library was already mapped, e.g.@: by an > > +earlier call to @code{LoadLibrary}. @var{aa} should be @samp{05}, the > > +trap signal. > > I think we need to explain what is ``hexname'' here, unless it is > already used and explained in the preceding portion of this section. It's explained at the target of the @pxref, where TextSeg and textaddr are also; is that OK? > Also, should we have some index entries here? Yep. > > +until the target responds with @samp{l} (lower-case el, for > ^^ > I believe the letter's name is ``ell''. "In reference, it is spelled el or ell." says Wikipedia; I actually copied this from a few lines further down in the manual. If there's some reason to change el -> ell let me know and I'll do it consistently. > > +Reply: > > +@table @samp > > +@item m Name=@var{hexname},TextSeg=@var{textaddr}@r{[},DataSeg=@var{dataaddr}@r{]} > > Does this long line look good in print? Yes, it seems to be OK; it's less than half the print area wide in the PDF. > > +@item m @var{library}; @var{library}@dots{} @r{[}; l@r{[} > > Did you really mean two left [ brackets here? Whoops! I'll have updated documentation in the revised patch, due soon. -- Daniel Jacobowitz CodeSourcery