From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: luisgpm@linux.vnet.ibm.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] "single step" atomic instruction sequences as a whole on PPC
Date: Wed, 09 May 2007 14:33:00 -0000 [thread overview]
Message-ID: <200705091433.l49EXOfG024847@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <1178580208.5101.2.camel@localhost> from "Luis Machado" at May 07, 2007 08:23:28 PM
Luis Machado wrote:
Actually, I think there's still a problem with the patch. Sorry for
not noticing earlier. You call:
> +#define BC_INSTRUCTION 0x40000000
> + const int opcode = BC_INSTRUCTION; /* Branch instruction's OPcode. */
> + branch_bp = branch_dest (opcode, insn, pc, breaks[0]);
branch_dest with 0x40000000 as opcode -- however, it appears the
routine expects to be called with just the opcode bits, i.e. 16
in the case of a conditional branch.
See the call in rs6000_software_single_step:
> opcode = insn >> 26;
> breaks[1] = branch_dest (opcode, insn, loc, breaks[0]);
Could you implement and test a patch to fix this, please?
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2007-05-09 14:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1177964763.15264.45.camel@localhost>
2007-05-02 14:08 ` uweigand
2007-05-03 14:51 ` Luis Machado
2007-05-06 21:20 ` Ulrich Weigand
2007-05-07 15:14 ` Luis Machado
2007-05-07 18:11 ` Ulrich Weigand
2007-05-07 19:28 ` Luis Machado
2007-05-07 22:47 ` Ulrich Weigand
2007-05-07 23:23 ` Luis Machado
2007-05-08 12:50 ` Ulrich Weigand
2007-05-09 14:33 ` Ulrich Weigand [this message]
2007-05-09 18:05 ` Luis Machado
2007-05-09 18:12 ` Daniel Jacobowitz
2007-05-09 18:21 ` Luis Machado
2007-05-09 18:34 ` Jan Kratochvil
2007-05-09 18:46 ` Daniel Jacobowitz
2007-05-09 19:10 ` Ulrich Weigand
2007-05-09 19:14 ` Luis Machado
2007-05-10 10:57 ` Emi SUZUKI
2007-05-10 21:31 ` Ulrich Weigand
2007-05-10 21:36 ` Daniel Jacobowitz
2007-05-10 22:58 ` Ulrich Weigand
2007-05-10 23:25 ` Daniel Jacobowitz
2007-05-11 7:34 ` Emi SUZUKI
2007-05-11 12:46 ` Ulrich Weigand
2007-05-09 19:45 ` Ulrich Weigand
2007-05-10 0:48 ` Luis Machado
2007-05-10 20:29 ` Ulrich Weigand
2007-04-09 2:13 Patch for gdb build on hppa hp-ux Daniel Jacobowitz
2007-04-09 23:25 ` Steve Ellcey
2007-04-10 12:05 ` Daniel Jacobowitz
2007-04-10 19:03 ` Eli Zaretskii
2007-04-10 20:22 ` Daniel Jacobowitz
2007-04-13 14:04 ` Daniel Jacobowitz
2007-04-13 17:07 ` [patch] "single step" atomic instruction sequences as a whole on PPC Luis Machado
2007-04-28 23:34 ` [RFC] " Luis Machado
2007-04-28 23:45 ` Ulrich Weigand
2007-04-29 1:53 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705091433.l49EXOfG024847@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox