From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25850 invoked by alias); 9 May 2007 14:33:30 -0000 Received: (qmail 25841 invoked by uid 22791); 9 May 2007 14:33:30 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 09 May 2007 14:33:27 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id l49EXO5D172958 for ; Wed, 9 May 2007 14:33:24 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l49EXONE1921222 for ; Wed, 9 May 2007 16:33:24 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l49EXOG8024850 for ; Wed, 9 May 2007 16:33:24 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l49EXOfG024847; Wed, 9 May 2007 16:33:24 +0200 Message-Id: <200705091433.l49EXOfG024847@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 9 May 2007 16:33:24 +0200 Subject: Re: [RFC] "single step" atomic instruction sequences as a whole on PPC To: luisgpm@linux.vnet.ibm.com Date: Wed, 09 May 2007 14:33:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <1178580208.5101.2.camel@localhost> from "Luis Machado" at May 07, 2007 08:23:28 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00129.txt.bz2 Luis Machado wrote: Actually, I think there's still a problem with the patch. Sorry for not noticing earlier. You call: > +#define BC_INSTRUCTION 0x40000000 > + const int opcode = BC_INSTRUCTION; /* Branch instruction's OPcode. */ > + branch_bp = branch_dest (opcode, insn, pc, breaks[0]); branch_dest with 0x40000000 as opcode -- however, it appears the routine expects to be called with just the opcode bits, i.e. 16 in the case of a conditional branch. See the call in rs6000_software_single_step: > opcode = insn >> 26; > breaks[1] = branch_dest (opcode, insn, loc, breaks[0]); Could you implement and test a patch to fix this, please? Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com