Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFC] legacy_virtual_frame_pointer: SP_REGNUM might be a  pseudo-register
Date: Mon, 07 May 2007 21:48:00 -0000	[thread overview]
Message-ID: <20070507144824.1110b520@ironwood.lan> (raw)

Any comments on the patch below?

I found this change necessary to avoid internal errors in some gdb.trace
tests when running against the mips simulator.

	* arch-utils.c (legacy_virtual_frame_pointer): SP_REGNUM might
	be a pseudo-register; revise test accordingly.

Index: arch-utils.c
===================================================================
RCS file: /cvs/src/src/gdb/arch-utils.c,v
retrieving revision 1.145
diff -u -p -r1.145 arch-utils.c
--- arch-utils.c	28 Apr 2007 21:52:38 -0000	1.145
+++ arch-utils.c	7 May 2007 21:39:03 -0000
@@ -198,7 +198,7 @@ legacy_virtual_frame_pointer (CORE_ADDR 
      with things like Dwarf2's CFI.  */
   if (DEPRECATED_FP_REGNUM >= 0 && DEPRECATED_FP_REGNUM < NUM_REGS)
     *frame_regnum = DEPRECATED_FP_REGNUM;
-  else if (SP_REGNUM >= 0 && SP_REGNUM < NUM_REGS)
+  else if (SP_REGNUM >= 0 && SP_REGNUM < NUM_REGS + NUM_PSEUDO_REGS)
     *frame_regnum = SP_REGNUM;
   else
     /* Should this be an internal error?  I guess so, it is reflecting


             reply	other threads:[~2007-05-07 21:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-07 21:48 Kevin Buettner [this message]
2007-05-07 22:35 ` Ulrich Weigand
2007-05-07 23:31 ` Daniel Jacobowitz
2007-05-08  2:36   ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070507144824.1110b520@ironwood.lan \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox