From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23759 invoked by alias); 7 May 2007 21:48:33 -0000 Received: (qmail 23742 invoked by uid 22791); 7 May 2007 21:48:32 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 07 May 2007 21:48:29 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l47LmQw8022080 for ; Mon, 7 May 2007 17:48:26 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l47LmPbW029667 for ; Mon, 7 May 2007 17:48:25 -0400 Received: from ironwood.lan (vpn-14-134.rdu.redhat.com [10.11.14.134]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l47LmOPU030787 for ; Mon, 7 May 2007 17:48:25 -0400 Date: Mon, 07 May 2007 21:48:00 -0000 From: Kevin Buettner To: gdb-patches@sources.redhat.com Subject: [RFC] legacy_virtual_frame_pointer: SP_REGNUM might be a pseudo-register Message-ID: <20070507144824.1110b520@ironwood.lan> X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.10.4; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00091.txt.bz2 Any comments on the patch below? I found this change necessary to avoid internal errors in some gdb.trace tests when running against the mips simulator. * arch-utils.c (legacy_virtual_frame_pointer): SP_REGNUM might be a pseudo-register; revise test accordingly. Index: arch-utils.c =================================================================== RCS file: /cvs/src/src/gdb/arch-utils.c,v retrieving revision 1.145 diff -u -p -r1.145 arch-utils.c --- arch-utils.c 28 Apr 2007 21:52:38 -0000 1.145 +++ arch-utils.c 7 May 2007 21:39:03 -0000 @@ -198,7 +198,7 @@ legacy_virtual_frame_pointer (CORE_ADDR with things like Dwarf2's CFI. */ if (DEPRECATED_FP_REGNUM >= 0 && DEPRECATED_FP_REGNUM < NUM_REGS) *frame_regnum = DEPRECATED_FP_REGNUM; - else if (SP_REGNUM >= 0 && SP_REGNUM < NUM_REGS) + else if (SP_REGNUM >= 0 && SP_REGNUM < NUM_REGS + NUM_PSEUDO_REGS) *frame_regnum = SP_REGNUM; else /* Should this be an internal error? I guess so, it is reflecting