Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: drow@false.org
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] Reduce target_thread_alive calls on GNU/Linux
Date: Mon, 07 May 2007 07:27:00 -0000	[thread overview]
Message-ID: <200705070727.l477R1BD002791@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20070507004909.GA23607@caradoc.them.org> (message from Daniel 	Jacobowitz on Sun, 6 May 2007 20:49:09 -0400)

> Date: Sun, 6 May 2007 20:49:09 -0400
> From: Daniel Jacobowitz <drow@false.org>
> Index: gdb/linux-thread-db.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/linux-thread-db.c,v
> retrieving revision 1.26
> diff -u -p -r1.26 linux-thread-db.c
> --- gdb/linux-thread-db.c	5 Feb 2007 20:02:51 -0000	1.26
> +++ gdb/linux-thread-db.c	6 May 2007 15:31:41 -0000
> @@ -486,9 +481,9 @@ enable_thread_event_reporting (void)
>    td_event_addset (&events, TD_CREATE);
>  
>  #ifdef HAVE_GNU_LIBC_VERSION_H
> -  /* FIXME: kettenis/2000-04-23: The event reporting facility is
> -     broken for TD_DEATH events in glibc 2.1.3, so don't enable it for
> -     now.  */
> +  /* The event reporting facility is broken for TD_DEATH events in
> +     glibc 2.1.3, so don't enable it we have glibc but a lower
> +     version.  */
>    libc_version = gnu_get_libc_version ();
>    if (sscanf (libc_version, "%d.%d", &libc_major, &libc_minor) == 2
>        && (libc_major > 2 || (libc_major == 2 && libc_minor > 1)))

I think there is a missing "if" in that comment.

Mark


  reply	other threads:[~2007-05-07  7:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-07  0:49 Daniel Jacobowitz
2007-05-07  7:27 ` Mark Kettenis [this message]
2007-05-11 17:43   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705070727.l477R1BD002791@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox