From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16951 invoked by alias); 7 May 2007 07:27:11 -0000 Received: (qmail 16941 invoked by uid 22791); 7 May 2007 07:27:10 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 07 May 2007 07:27:07 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.0/8.14.0) with ESMTP id l477R2Pd009291; Mon, 7 May 2007 09:27:02 +0200 (CEST) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.0/8.14.0/Submit) id l477R1BD002791; Mon, 7 May 2007 09:27:01 +0200 (CEST) Date: Mon, 07 May 2007 07:27:00 -0000 Message-Id: <200705070727.l477R1BD002791@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: drow@false.org CC: gdb-patches@sourceware.org In-reply-to: <20070507004909.GA23607@caradoc.them.org> (message from Daniel Jacobowitz on Sun, 6 May 2007 20:49:09 -0400) Subject: Re: [commit] Reduce target_thread_alive calls on GNU/Linux References: <20070507004909.GA23607@caradoc.them.org> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00081.txt.bz2 > Date: Sun, 6 May 2007 20:49:09 -0400 > From: Daniel Jacobowitz > Index: gdb/linux-thread-db.c > =================================================================== > RCS file: /cvs/src/src/gdb/linux-thread-db.c,v > retrieving revision 1.26 > diff -u -p -r1.26 linux-thread-db.c > --- gdb/linux-thread-db.c 5 Feb 2007 20:02:51 -0000 1.26 > +++ gdb/linux-thread-db.c 6 May 2007 15:31:41 -0000 > @@ -486,9 +481,9 @@ enable_thread_event_reporting (void) > td_event_addset (&events, TD_CREATE); > > #ifdef HAVE_GNU_LIBC_VERSION_H > - /* FIXME: kettenis/2000-04-23: The event reporting facility is > - broken for TD_DEATH events in glibc 2.1.3, so don't enable it for > - now. */ > + /* The event reporting facility is broken for TD_DEATH events in > + glibc 2.1.3, so don't enable it we have glibc but a lower > + version. */ > libc_version = gnu_get_libc_version (); > if (sscanf (libc_version, "%d.%d", &libc_major, &libc_minor) == 2 > && (libc_major > 2 || (libc_major == 2 && libc_minor > 1))) I think there is a missing "if" in that comment. Mark