From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Remove mips/tm-linux.h
Date: Tue, 01 May 2007 23:37:00 -0000 [thread overview]
Message-ID: <20070501233716.GA32508@caradoc.them.org> (raw)
In-Reply-To: <200705012307.l41N7h4n010988@d12av02.megacenter.de.ibm.com>
On Wed, May 02, 2007 at 01:07:43AM +0200, Ulrich Weigand wrote:
> Then mips gdbarch could override that method, and call the
> standard in_solib_dynsym_resolve_code plus its own special
> check for dynamic stubs.
Right - that would work too. I'll skip it for now, though, since
there's only one place that needed it.
> > Tested on mips64-linux, all three ABIs, no change in results.
>
> I'm wondering why you didn't run into this #error in gdbarch.h:
>
> #if !defined (GDB_TM_FILE) && defined (CANNOT_FETCH_REGISTER)
> #error "Non multi-arch definition of CANNOT_FETCH_REGISTER"
> #endif
>
> #if !defined (GDB_TM_FILE) && defined (CANNOT_STORE_REGISTER)
> #error "Non multi-arch definition of CANNOT_STORE_REGISTER"
> #endif
>
> because the mips-linux NM file still defines those two macros,
> and you just removed the TM file ...
>
> I did run into the that problem on ia64. That's the reason
> why I was recently trying to remove the mips-linux NM file,
> before going after the TM -- but that still isn't quite
> resolved.
Thank you! I hadn't noticed, because I don't generally build native
mips64-linux debuggers; it was a cross. I'll be sure not to commit
this until we resolve that.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-05-01 23:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 20:27 Daniel Jacobowitz
2007-05-01 23:07 ` Ulrich Weigand
2007-05-01 23:37 ` Daniel Jacobowitz [this message]
2007-05-16 14:09 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070501233716.GA32508@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox