From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13471 invoked by alias); 1 May 2007 23:37:24 -0000 Received: (qmail 13462 invoked by uid 22791); 1 May 2007 23:37:23 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 01 May 2007 23:37:21 +0000 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 6A4AF4B267; Tue, 1 May 2007 18:37:19 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 71ECB4B262; Tue, 1 May 2007 18:37:17 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1Hj1uG-00004x-L0; Tue, 01 May 2007 19:37:16 -0400 Date: Tue, 01 May 2007 23:37:00 -0000 From: Daniel Jacobowitz To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfc] Remove mips/tm-linux.h Message-ID: <20070501233716.GA32508@caradoc.them.org> Mail-Followup-To: Ulrich Weigand , gdb-patches@sourceware.org References: <20070501202710.GA23630@caradoc.them.org> <200705012307.l41N7h4n010988@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200705012307.l41N7h4n010988@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00022.txt.bz2 On Wed, May 02, 2007 at 01:07:43AM +0200, Ulrich Weigand wrote: > Then mips gdbarch could override that method, and call the > standard in_solib_dynsym_resolve_code plus its own special > check for dynamic stubs. Right - that would work too. I'll skip it for now, though, since there's only one place that needed it. > > Tested on mips64-linux, all three ABIs, no change in results. > > I'm wondering why you didn't run into this #error in gdbarch.h: > > #if !defined (GDB_TM_FILE) && defined (CANNOT_FETCH_REGISTER) > #error "Non multi-arch definition of CANNOT_FETCH_REGISTER" > #endif > > #if !defined (GDB_TM_FILE) && defined (CANNOT_STORE_REGISTER) > #error "Non multi-arch definition of CANNOT_STORE_REGISTER" > #endif > > because the mips-linux NM file still defines those two macros, > and you just removed the TM file ... > > I did run into the that problem on ia64. That's the reason > why I was recently trying to remove the mips-linux NM file, > before going after the TM -- but that still isn't quite > resolved. Thank you! I hadn't noticed, because I don't generally build native mips64-linux debuggers; it was a cross. I'll be sure not to commit this until we resolve that. -- Daniel Jacobowitz CodeSourcery