From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfa] Eliminate supply_gregset etc. from -tdep files
Date: Sun, 29 Apr 2007 17:15:00 -0000 [thread overview]
Message-ID: <20070429164613.GB27509@caradoc.them.org> (raw)
In-Reply-To: <200704291618.l3TGIOoh025532@d12av02.megacenter.de.ibm.com>
On Sun, Apr 29, 2007 at 06:18:24PM +0200, Ulrich Weigand wrote:
> Hello,
>
> there are two -tdep files (m68k-tdep.c and mips-linux-tdep.c) that contain
> implementations of the supply_greget family of functions. This is incorrect;
> those function should only ever be provided by native support files.
"Incorrect" may be a bit strong. core-regset.c needs them to link; at
one point, that was the right way to implement core file support. I
don't remember how the history worked out for mips, since it doesn't
look like the version in the FSF repository ever used core-regset.o,
but I think that was the original motivation.
Anyway, now there are no targets that use core-regset.o in .mt files,
and no good reason to do so. So now it's incorrect :-) This patch is
OK.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-04-29 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-29 16:37 Ulrich Weigand
2007-04-29 17:15 ` Daniel Jacobowitz [this message]
2007-04-29 20:11 ` Ulrich Weigand
2007-04-30 12:27 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070429164613.GB27509@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox