From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31386 invoked by alias); 29 Apr 2007 16:46:19 -0000 Received: (qmail 31377 invoked by uid 22791); 29 Apr 2007 16:46:19 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 29 Apr 2007 17:46:17 +0100 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 774D14B26F; Sun, 29 Apr 2007 11:46:16 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 470154B26D; Sun, 29 Apr 2007 11:46:14 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1HiCXN-0007d7-QQ; Sun, 29 Apr 2007 12:46:13 -0400 Date: Sun, 29 Apr 2007 17:15:00 -0000 From: Daniel Jacobowitz To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfa] Eliminate supply_gregset etc. from -tdep files Message-ID: <20070429164613.GB27509@caradoc.them.org> Mail-Followup-To: Ulrich Weigand , gdb-patches@sourceware.org References: <200704291618.l3TGIOoh025532@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200704291618.l3TGIOoh025532@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00399.txt.bz2 On Sun, Apr 29, 2007 at 06:18:24PM +0200, Ulrich Weigand wrote: > Hello, > > there are two -tdep files (m68k-tdep.c and mips-linux-tdep.c) that contain > implementations of the supply_greget family of functions. This is incorrect; > those function should only ever be provided by native support files. "Incorrect" may be a bit strong. core-regset.c needs them to link; at one point, that was the right way to implement core file support. I don't remember how the history worked out for mips, since it doesn't look like the version in the FSF repository ever used core-regset.o, but I think that was the original motivation. Anyway, now there are no targets that use core-regset.o in .mt files, and no good reason to do so. So now it's incorrect :-) This patch is OK. -- Daniel Jacobowitz CodeSourcery