Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: gdb-patches@sourceware.org
Subject: [rfc] [4/7] Modernize AIX target: inf-ptrace build fix
Date: Tue, 24 Apr 2007 21:38:00 -0000	[thread overview]
Message-ID: <200704242137.l3OLbODT007089@d12av02.megacenter.de.ibm.com> (raw)

Hello,

this is another small build fix that is a pre-requisite for the
next patch (which adds inf-ptrace.c on AIX).  The problem is that
on AIX, PTRACE_TYPE_ARG3 is a pointer, and trying to cast a
CORE_ADDR directly to it gives a compile warning.

The patch adds an intermediate cast to "long" to fix this problem;
there is precedent for this method in inf_ptrace_xfer_partial.

Tested on powerpc-aix-ibm5.3.0.0.

Bye,
Ulrich


ChangeLog:

	* inf-ptrace.c (inf_ptrace_fetch_register): Add intermediate cast
	to "long" before casting CORE_ADDR to PTRACE_TYPE_ARG3.
	(inf_ptrace_store_register): Likewise.


diff -urNp gdb-orig/gdb/inf-ptrace.c gdb-head/gdb/inf-ptrace.c
--- gdb-orig/gdb/inf-ptrace.c	Wed Apr 18 16:17:19 2007
+++ gdb-head/gdb/inf-ptrace.c	Mon Apr 23 21:14:20 2007
@@ -642,7 +642,7 @@ inf_ptrace_fetch_register (int regnum)
   for (i = 0; i < size / sizeof (PTRACE_TYPE_RET); i++)
     {
       errno = 0;
-      buf[i] = ptrace (PT_READ_U, pid, (PTRACE_TYPE_ARG3)addr, 0);
+      buf[i] = ptrace (PT_READ_U, pid, (PTRACE_TYPE_ARG3)(long)addr, 0);
       if (errno != 0)
 	error (_("Couldn't read register %s (#%d): %s."),
 	       REGISTER_NAME (regnum), regnum, safe_strerror (errno));
@@ -696,7 +696,7 @@ inf_ptrace_store_register (int regnum)
   for (i = 0; i < size / sizeof (PTRACE_TYPE_RET); i++)
     {
       errno = 0;
-      ptrace (PT_WRITE_U, pid, (PTRACE_TYPE_ARG3)addr, buf[i]);
+      ptrace (PT_WRITE_U, pid, (PTRACE_TYPE_ARG3)(long)addr, buf[i]);
       if (errno != 0)
 	error (_("Couldn't write register %s (#%d): %s."),
 	       REGISTER_NAME (regnum), regnum, safe_strerror (errno));
-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


             reply	other threads:[~2007-04-24 21:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-24 21:38 Ulrich Weigand [this message]
2007-04-25  0:16 ` Mark Kettenis
2007-04-25  1:25   ` Ulrich Weigand
2007-04-25  3:09     ` Daniel Jacobowitz
2007-04-26  0:15       ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704242137.l3OLbODT007089@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox