From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21212 invoked by alias); 24 Apr 2007 21:37:29 -0000 Received: (qmail 21164 invoked by uid 22791); 24 Apr 2007 21:37:29 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 24 Apr 2007 22:37:27 +0100 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id l3OLbO0a033124 for ; Tue, 24 Apr 2007 21:37:24 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l3OLbOMp3776680 for ; Tue, 24 Apr 2007 23:37:24 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l3OLbOPg007092 for ; Tue, 24 Apr 2007 23:37:24 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l3OLbODT007089 for ; Tue, 24 Apr 2007 23:37:24 +0200 Message-Id: <200704242137.l3OLbODT007089@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 24 Apr 2007 23:37:24 +0200 Subject: [rfc] [4/7] Modernize AIX target: inf-ptrace build fix To: gdb-patches@sourceware.org Date: Tue, 24 Apr 2007 21:38:00 -0000 From: "Ulrich Weigand" X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00325.txt.bz2 Hello, this is another small build fix that is a pre-requisite for the next patch (which adds inf-ptrace.c on AIX). The problem is that on AIX, PTRACE_TYPE_ARG3 is a pointer, and trying to cast a CORE_ADDR directly to it gives a compile warning. The patch adds an intermediate cast to "long" to fix this problem; there is precedent for this method in inf_ptrace_xfer_partial. Tested on powerpc-aix-ibm5.3.0.0. Bye, Ulrich ChangeLog: * inf-ptrace.c (inf_ptrace_fetch_register): Add intermediate cast to "long" before casting CORE_ADDR to PTRACE_TYPE_ARG3. (inf_ptrace_store_register): Likewise. diff -urNp gdb-orig/gdb/inf-ptrace.c gdb-head/gdb/inf-ptrace.c --- gdb-orig/gdb/inf-ptrace.c Wed Apr 18 16:17:19 2007 +++ gdb-head/gdb/inf-ptrace.c Mon Apr 23 21:14:20 2007 @@ -642,7 +642,7 @@ inf_ptrace_fetch_register (int regnum) for (i = 0; i < size / sizeof (PTRACE_TYPE_RET); i++) { errno = 0; - buf[i] = ptrace (PT_READ_U, pid, (PTRACE_TYPE_ARG3)addr, 0); + buf[i] = ptrace (PT_READ_U, pid, (PTRACE_TYPE_ARG3)(long)addr, 0); if (errno != 0) error (_("Couldn't read register %s (#%d): %s."), REGISTER_NAME (regnum), regnum, safe_strerror (errno)); @@ -696,7 +696,7 @@ inf_ptrace_store_register (int regnum) for (i = 0; i < size / sizeof (PTRACE_TYPE_RET); i++) { errno = 0; - ptrace (PT_WRITE_U, pid, (PTRACE_TYPE_ARG3)addr, buf[i]); + ptrace (PT_WRITE_U, pid, (PTRACE_TYPE_ARG3)(long)addr, buf[i]); if (errno != 0) error (_("Couldn't write register %s (#%d): %s."), REGISTER_NAME (regnum), regnum, safe_strerror (errno)); -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com