From: Daniel Jacobowitz <drow@false.org>
To: Anton Blanchard <anton@samba.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix powerpc 64bit backtrace code
Date: Tue, 27 Mar 2007 19:05:00 -0000 [thread overview]
Message-ID: <20070327190513.GF28164@caradoc.them.org> (raw)
In-Reply-To: <20060608184134.GD26368@nevyn.them.org>
On Thu, Jun 08, 2006 at 02:41:34PM -0400, Daniel Jacobowitz wrote:
> On Fri, Jun 02, 2006 at 12:38:24PM +1000, Anton Blanchard wrote:
> > Knowing this I looked through the backtrace code and it looks like the
> > fallback is incorrect. If we fail to determine the stack layout
> > accurately we should make a guess based on the ABI. It turns out
> > tdep->lr_frame_offset was created for this purpose, but isnt used
> > anywhere.
>
> Yep. It was used, but that code is long gone; I think I added the
> fallback you're fixing, but I didn't know about lr_frame_offset.
> The patch looks right.
>
> Do you have write access to src? If so, you can check this in and add
> your name to write-after-approval in MAINTAINERS. Or I can check it in
> for you; just let me know which.
Andreas Schwab pointed out that I'd never heard back. So I went ahead
and checked this in.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2007-03-27 19:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-02 2:40 Anton Blanchard
2006-06-08 18:41 ` Daniel Jacobowitz
2007-03-27 19:05 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070327190513.GF28164@caradoc.them.org \
--to=drow@false.org \
--cc=anton@samba.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox