From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3822 invoked by alias); 27 Mar 2007 19:05:21 -0000 Received: (qmail 3814 invoked by uid 22791); 27 Mar 2007 19:05:20 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 27 Mar 2007 20:05:17 +0100 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 803364B270; Tue, 27 Mar 2007 14:05:16 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 4C1494B267; Tue, 27 Mar 2007 14:05:14 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HWGyn-00011y-Ru; Tue, 27 Mar 2007 15:05:13 -0400 Date: Tue, 27 Mar 2007 19:05:00 -0000 From: Daniel Jacobowitz To: Anton Blanchard , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix powerpc 64bit backtrace code Message-ID: <20070327190513.GF28164@caradoc.them.org> Mail-Followup-To: Anton Blanchard , gdb-patches@sourceware.org References: <20060602023824.GC1736@krispykreme> <20060608184134.GD26368@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060608184134.GD26368@nevyn.them.org> User-Agent: Mutt/1.5.14+cvs20070313 (2007-03-13) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00265.txt.bz2 On Thu, Jun 08, 2006 at 02:41:34PM -0400, Daniel Jacobowitz wrote: > On Fri, Jun 02, 2006 at 12:38:24PM +1000, Anton Blanchard wrote: > > Knowing this I looked through the backtrace code and it looks like the > > fallback is incorrect. If we fail to determine the stack layout > > accurately we should make a guess based on the ABI. It turns out > > tdep->lr_frame_offset was created for this purpose, but isnt used > > anywhere. > > Yep. It was used, but that code is long gone; I think I added the > fallback you're fixing, but I didn't know about lr_frame_offset. > The patch looks right. > > Do you have write access to src? If so, you can check this in and add > your name to write-after-approval in MAINTAINERS. Or I can check it in > for you; just let me know which. Andreas Schwab pointed out that I'd never heard back. So I went ahead and checked this in. -- Daniel Jacobowitz CodeSourcery