[RFA] typo in gdb/utils.c

[RFA] typo in gdb/utils.c

[Denis PILAT]

[-- Attachment #1: Type: text/plain, Size: 94 bytes --]

This trivial patch fixes a typo to declare pagination_off_command in 
gdb/utils.c

-- 
Denis


[-- Attachment #2: utils.c.patch --]
[-- Type: text/plain, Size: 640 bytes --]

2007-03-07  Denis Pilat  <denis.pilat@st.com>

	* utils.c (pagination_off_command): Declaration.

Index: utils.c
===================================================================
RCS file: /cvs/src/src/gdb/utils.c,v
retrieving revision 1.174
diff -u -p -r1.174 utils.c
--- utils.c	8 Feb 2007 16:18:56 -0000	1.174
+++ utils.c	21 Mar 2007 15:11:40 -0000
@@ -2448,7 +2448,7 @@ pagination_on_command (char *arg, int fr
   pagination_enabled = 1;
 }
 
-static void pagination_on_command (char *arg, int from_tty);
+static void pagination_off_command (char *arg, int from_tty);
 static void
 pagination_off_command (char *arg, int from_tty)
 {

Re: [RFA] typo in gdb/utils.c

[Denis PILAT]

I could also remove the declaration but I don't know if some old 
compiler needs it !

-- 
Denis

Denis PILAT wrote:
> This trivial patch fixes a typo to declare pagination_off_command in 
> gdb/utils.c
>
> ------------------------------------------------------------------------
>
> 2007-03-07  Denis Pilat  <denis.pilat@st.com>
>
> 	* utils.c (pagination_off_command): Declaration.
>
> Index: utils.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/utils.c,v
> retrieving revision 1.174
> diff -u -p -r1.174 utils.c
> --- utils.c	8 Feb 2007 16:18:56 -0000	1.174
> +++ utils.c	21 Mar 2007 15:11:40 -0000
> @@ -2448,7 +2448,7 @@ pagination_on_command (char *arg, int fr
>    pagination_enabled = 1;
>  }
>  
> -static void pagination_on_command (char *arg, int from_tty);
> +static void pagination_off_command (char *arg, int from_tty);
>  static void
>  pagination_off_command (char *arg, int from_tty)
>  {
>   

Re: [RFA] typo in gdb/utils.c

[Andreas Schwab]

Denis PILAT <denis.pilat@st.com> writes:

> I could also remove the declaration

That would be preferable, since the definition is already a prototype.

> but I don't know if some old compiler needs it !

GDB requires at least C89 anyway.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [RFA] typo in gdb/utils.c

[Mark Kettenis]

> Date: Wed, 21 Mar 2007 16:16:48 +0100
> From: Denis PILAT <denis.pilat@st.com>
> 
> This trivial patch fixes a typo to declare pagination_off_command in 
> gdb/utils.c

Just whack the (redundant) prototype instead.

> Index: utils.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/utils.c,v
> retrieving revision 1.174
> diff -u -p -r1.174 utils.c
> --- utils.c	8 Feb 2007 16:18:56 -0000	1.174
> +++ utils.c	21 Mar 2007 15:11:40 -0000
> @@ -2448,7 +2448,7 @@ pagination_on_command (char *arg, int fr
>    pagination_enabled = 1;
>  }
>  
> -static void pagination_on_command (char *arg, int from_tty);
> +static void pagination_off_command (char *arg, int from_tty);
>  static void
>  pagination_off_command (char *arg, int from_tty)
>  {

Re: [RFA] typo in gdb/utils.c

[Denis PILAT]

>> This trivial patch fixes a typo to declare pagination_off_command in 
>> gdb/utils.c
>>     
>
> Just whack the (redundant) prototype instead.
>
>   
I've removed both useless prototypes.
Committed this morning, attached patch:

-- 
Denis


2007-03-22  Denis Pilat  <denis.pilat@st.com>

	* utils.c (pagination_on_command, pagination_off_command):
	Remove useless prototypes.

Index: utils.c
===================================================================
RCS file: /cvs/src/src/gdb/utils.c,v
retrieving revision 1.174
diff -u -p -r1.174 utils.c
--- utils.c     8 Feb 2007 16:18:56 -0000       1.174
+++ utils.c     22 Mar 2007 09:53:05 -0000
@@ -2440,15 +2440,12 @@ subset_compare (char *string_to_compare,
   return match;
 }

-
-static void pagination_on_command (char *arg, int from_tty);
 static void
 pagination_on_command (char *arg, int from_tty)
 {
   pagination_enabled = 1;
 }

-static void pagination_on_command (char *arg, int from_tty);
 static void
 pagination_off_command (char *arg, int from_tty)
 {

Re: [RFA] typo in gdb/utils.c

[Mark Kettenis]

> Date: Thu, 22 Mar 2007 10:59:37 +0100
> From: Denis PILAT <denis.pilat@st.com>
> 
> >> This trivial patch fixes a typo to declare pagination_off_command in 
> >> gdb/utils.c
> >>     
> >
> > Just whack the (redundant) prototype instead.
> >
> >   
> I've removed both useless prototypes.

Thanks!