From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>,
Vladimir Prus <vladimir@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] varobj.c
Date: Tue, 27 Feb 2007 17:04:00 -0000 [thread overview]
Message-ID: <20070227170403.GF31729@caradoc.them.org> (raw)
In-Reply-To: <17875.38347.137214.962583@kahikatea.snap.net.nz>
On Thu, Feb 15, 2007 at 12:05:47PM +1300, Nick Roberts wrote:
>
> Following Denis' patch, this patch makes GDB throw a user error if a non
> root variable is used for -var-update. Currently GDB does:
>
> (gdb)
> -var-update var1.1
> ^done,changelist=[{name="var1.1",in_scope="false"}]
> (gdb)
>
> even though the expression that var1.1 represents may be inscope and have
> changed value.
Vladimir, didn't you have some in-progress patch that actually wanted
to update root varobjs? Anyway, if so, we can change it back later.
> 2007-02-15 Nick Roberts <nickrob@snap.net.nz>
>
> * varobj.c (varobj_update): Remove unused local. Use gdb_assert
> to check changelist is non-NULL. Call error if the frontend tries
> to update a non-root variable.
>
> * varobj.h (enum varobj_update_error): Delete WRONG_PARAM value.
OK.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-02-27 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-14 23:06 Nick Roberts
2007-02-27 17:04 ` Daniel Jacobowitz [this message]
2007-02-28 6:36 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070227170403.GF31729@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=nickrob@snap.net.nz \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox