From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17564 invoked by alias); 27 Feb 2007 17:04:15 -0000 Received: (qmail 17555 invoked by uid 22791); 27 Feb 2007 17:04:14 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 27 Feb 2007 17:04:09 +0000 Received: from dsl093-172-095.pit1.dsl.speakeasy.net ([66.93.172.95] helo=caradoc.them.org) by nevyn.them.org with esmtp (Exim 4.63) (envelope-from ) id 1HM5kC-0007u8-5G; Tue, 27 Feb 2007 12:04:04 -0500 Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HM5kB-0000AW-TE; Tue, 27 Feb 2007 12:04:03 -0500 Date: Tue, 27 Feb 2007 17:04:00 -0000 From: Daniel Jacobowitz To: Nick Roberts , Vladimir Prus Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] varobj.c Message-ID: <20070227170403.GF31729@caradoc.them.org> Mail-Followup-To: Nick Roberts , Vladimir Prus , gdb-patches@sourceware.org References: <17875.38347.137214.962583@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17875.38347.137214.962583@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00336.txt.bz2 On Thu, Feb 15, 2007 at 12:05:47PM +1300, Nick Roberts wrote: > > Following Denis' patch, this patch makes GDB throw a user error if a non > root variable is used for -var-update. Currently GDB does: > > (gdb) > -var-update var1.1 > ^done,changelist=[{name="var1.1",in_scope="false"}] > (gdb) > > even though the expression that var1.1 represents may be inscope and have > changed value. Vladimir, didn't you have some in-progress patch that actually wanted to update root varobjs? Anyway, if so, we can change it back later. > 2007-02-15 Nick Roberts > > * varobj.c (varobj_update): Remove unused local. Use gdb_assert > to check changelist is non-NULL. Call error if the frontend tries > to update a non-root variable. > > * varobj.h (enum varobj_update_error): Delete WRONG_PARAM value. OK. -- Daniel Jacobowitz CodeSourcery