From: Daniel Jacobowitz <dan@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Gabriel Dos Reis <gdr@cs.tamu.edu>, gdb-patches@sourceware.org
Subject: Re: PATCH to gdb/ada-lang.c
Date: Fri, 09 Feb 2007 20:25:00 -0000 [thread overview]
Message-ID: <20070209202545.GA998@nevyn.them.org> (raw)
In-Reply-To: <20070209202527.GF3365@adacore.com>
On Fri, Feb 09, 2007 at 12:25:27PM -0800, Joel Brobecker wrote:
> Hello Gaby,
>
> Thanks for your patch.
>
> > 2007-02-09 Gabriel Dos Reis <gdr@integrable-solutions.net>
> >
> > * ada-lang.c (remove_out_of_scope_renamings): Change third parameter's
> > type to a pointer to const struct block.
> > (ada_lookup_symbol_list): Don't cast away constness when calling
> > remove_out_of_scope_renamings.
>
> I had a look, and although I cannot approve your change, I agree
> with your conclusions and your patch.
Good enough for me; is OK.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-02-09 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 12:25 Gabriel Dos Reis
2007-02-09 20:24 ` Joel Brobecker
2007-02-09 20:25 ` Daniel Jacobowitz [this message]
2007-02-09 20:46 ` Gabriel Dos Reis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070209202545.GA998@nevyn.them.org \
--to=dan@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=gdr@cs.tamu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox