From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14669 invoked by alias); 9 Feb 2007 20:25:56 -0000 Received: (qmail 14653 invoked by uid 22791); 9 Feb 2007 20:25:55 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 09 Feb 2007 20:25:51 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1HFcJV-0000GR-Oe; Fri, 09 Feb 2007 15:25:45 -0500 Date: Fri, 09 Feb 2007 20:25:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: Gabriel Dos Reis , gdb-patches@sourceware.org Subject: Re: PATCH to gdb/ada-lang.c Message-ID: <20070209202545.GA998@nevyn.them.org> Mail-Followup-To: Joel Brobecker , Gabriel Dos Reis , gdb-patches@sourceware.org References: <8764ab4iy2.fsf@soliton.cs.tamu.edu> <20070209202527.GF3365@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070209202527.GF3365@adacore.com> User-Agent: Mutt/1.5.13 (2006-08-11) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00146.txt.bz2 On Fri, Feb 09, 2007 at 12:25:27PM -0800, Joel Brobecker wrote: > Hello Gaby, > > Thanks for your patch. > > > 2007-02-09 Gabriel Dos Reis > > > > * ada-lang.c (remove_out_of_scope_renamings): Change third parameter's > > type to a pointer to const struct block. > > (ada_lookup_symbol_list): Don't cast away constness when calling > > remove_out_of_scope_renamings. > > I had a look, and although I cannot approve your change, I agree > with your conclusions and your patch. Good enough for me; is OK. -- Daniel Jacobowitz CodeSourcery