Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: XML XInclude support
Date: Thu, 08 Feb 2007 13:57:00 -0000	[thread overview]
Message-ID: <20070208135651.GA5269@nevyn.them.org> (raw)
In-Reply-To: <200702081345.l18DjWo9029777@brahms.sibelius.xs4all.nl>

On Thu, Feb 08, 2007 at 02:45:32PM +0100, Mark Kettenis wrote:
> > Could you try replacing that line with this, to avoid the % being
> > interpreted as a format specifier?
> > 
> > 	printf "'\''%c'\'', ", c
> 
> That seems to work, Thanks!

Oof - glad I checked; that's wrong.  I've committed this instead,
which should still work for you, but not leave binary gunk in the file.
%c interprets 'a' as a character but '0' as an ASCII code.

Ever feel like I accomplish nothing except breaking your builds? :-)

-- 
Daniel Jacobowitz
CodeSourcery

2007-02-08  Daniel Jacobowitz  <dan@codesourcery.com>

	* features/feature_to_c.sh: Use %s to avoid problems with nawk.

Index: gdb/features/feature_to_c.sh
===================================================================
RCS file: /cvs/src/src/gdb/features/feature_to_c.sh,v
retrieving revision 1.2
diff -u -p -r1.2 feature_to_c.sh
--- gdb/features/feature_to_c.sh	7 Feb 2007 22:48:06 -0000	1.2
+++ gdb/features/feature_to_c.sh	8 Feb 2007 13:55:08 -0000
@@ -51,7 +51,7 @@ for input; do
         } else if (c == "\\") {
           printf "'\''\\\\'\'', "
         } else if (_ord_[c] >= 32 && _ord_[c] < 127) {
-          printf "'\''" c "'\'', "
+	  printf "'\''%s'\'', ", c
         } else {
           printf "'\''\\%03o'\'', ", _ord_[c]
         }


  reply	other threads:[~2007-02-08 13:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-29 21:32 Daniel Jacobowitz
2007-01-31 18:33 ` Daniel Jacobowitz
2007-02-02 18:53 ` Eli Zaretskii
2007-02-06 12:49   ` Daniel Jacobowitz
2007-02-07 18:16     ` Eli Zaretskii
2007-02-07 18:37       ` Daniel Jacobowitz
2007-02-07 18:45         ` Daniel Jacobowitz
2007-02-07 22:49           ` Daniel Jacobowitz
2007-02-08 13:06             ` Mark Kettenis
2007-02-08 13:14               ` Daniel Jacobowitz
2007-02-08 16:15                 ` Mark Kettenis
2007-02-08 13:57                   ` Daniel Jacobowitz [this message]
2007-02-06 13:03   ` Daniel Jacobowitz
2007-02-07 18:20     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070208135651.GA5269@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox